-
Notifications
You must be signed in to change notification settings - Fork 52
Add system architecture diagram to README #1586
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
I think it is a great addition, but media (mermaid) is not advanced enough for such a complex software. A safer approach I think is cut and paste structural diagram(s) verbatim from Pierre presentations, conference poster or other publications. As it was noted in slack, the accuracy is questionable.
|
|
verbiage needs a check e.g, in Bourreau can also fetch and stage data from providers as part of backend task execution. can is redundant if not misleading |
MontrealSergiy
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok with me
MontrealSergiy
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
normally bourraux do not use ssh to access Slurm, please correct
'
|
Please assign yourself, add Documentation label |
|
Just FYI, there could be local data providers and Bourreau ( do not add them to the diagram, it is already big) I would have two separate External Compute and External Storage resources (flat is better than nested) |
|
There is no HTTP Data Provider! Also maybe instead of two identical Data Providers have one with ssh another s3 ? |
|
btw ftp is not secure, nothing to brag about even if it supported. Maybe best mention datalad, squashfs, or at least sftp |
|
@MontrealSergiy We don't use FTP anywhere. We use SFTP. |
|
Therefore ftp should not appear on the diagram |
Motivation
Description
## System architecturesection with a Mermaidflowchartdiagram toREADME.mdthat models users, NeuroHub, BrainPortal, the shared database, data providers, Bourreau, HPC scheduler, compute nodes, and shared scratch.README.mdand committed with the messageAdd system architecture diagram to README.Testing
Codex Task