Skip to content

Adding sound to dialogues, Undertale style#10

Closed
dmytrove wants to merge 2 commits into
achtaitaipai:mainfrom
dmytrove:sound/dialog
Closed

Adding sound to dialogues, Undertale style#10
dmytrove wants to merge 2 commits into
achtaitaipai:mainfrom
dmytrove:sound/dialog

Conversation

@dmytrove

Copy link
Copy Markdown
Contributor

Using PFXR to generate sound and using it as sample for MIDI. Otherwise, playing many PFXR sounds directly was leading to issues with page playback.

@achtaitaipai

Copy link
Copy Markdown
Owner

Wow, this is great! I hadn’t thought of it, but it really adds something. It makes the characters feel like they have personality, which is super cool.

That said, I do have a few questions about the API.

I really like the idea of "voices", but I find it a bit odd to reuse PFXR template names like laser or pickup, especially since the generated sounds aren’t exactly the same and the context is quite different. It might be a bit misleading for the user.

I’m wondering if we should move away from PFXR templates for this part and instead design voice-specific templates with a more narrative feel. Something like ROBOT, GHOST, MONSTER, or ALIEN, names that evoke character or intent. We could start with just one or two and expand later as needed.

That would make the API clearer and better aligned with the purpose of this feature.

What do you think?

@dmytrove

Copy link
Copy Markdown
Contributor Author

Agreed, I wanted to show you the possibilities first.

I'll think about this and come back with reviewed plan, thanks!

@dmytrove

Copy link
Copy Markdown
Contributor Author

Please check #19

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants