-
Notifications
You must be signed in to change notification settings - Fork 0
feat: initial implementation of the Projects and Repo pages #1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Sorry guys, I requested a review by mistake (habit). |
|
No problem, and I really love the idea! |
I'm not sure if I understood the question correctly, sorry in advance. It already lists the logos-co repositories: It fetches the list of repositories from the Github API, so it should automatically reflect right away if another repo gets created. |
|
@nipsysdev |
|
I agree this is a very nice idea! I'm working on the API right now so we might have overlapping code, let's be careful when we merge everything |
|
On a different note, I think we could add a Contributors section to README.md, similar to this one: https://github.com/status-im/translate.status.im?tab=readme-ov-file#contributors What do you think? |
We would display the contributors from all the Logos repositories or only the contributors of |
|
@nipsysdev It depends on our decision. I think listing all the unique contributors across the Logos repos is idealistic, but we can start by listing contributors for this repo first and then find a way to scale it out later. |
|
@nipsysdev after discussing it with Jinho we think that it makes more sense to just display the contributors of this repo ( |
|
Hey @nipsysdev, we've made many changes to the project since you first opened this PR; a big one related to your work is that we migrated all the api logic to a separated backend to make the frontend fully static. This means that we have to migrate the two routes you created, /api/pull-requests & /api/repositories, to this backend. I will handle this task - are these two routes still relevant for your work? I would need to do the following changes before shipping your PR:
I also remember that you wanted to do a review of you code before we ship it, if you still do I think it's better that you do it before I do the migration and conflicts resolve. Would that be ok with you? |
|
Hi guys sorry for the late reply.
Makes total sense. I agree!
Yes please migrate the API routes to the backend and let me know when the endpoints are ready to be used. I've made myself available to finalize this PR so I can take care of the conflict merging. Once I'm done I'll request a review from you guys yes. |
|
@nipsysdev great I'm working on it, let me get back to you when ready! |
|
Re @nipsysdev, job is done :). I'm just waiting for the infra team to perform the deployment on the dev branch as the automatic ci/cd pipeline is not ready yet (will be soon) so it requires manual deployment. In the meantime here are the details of the new API routes that will be available:
{ orgs: string[] }
type MinimalRepository = {
id: number
name: string
full_name: string
html_url: string
description: string | null
language: string | null
stargazers_count: number
forks_count: number
open_issues_count: number
updated_at: string // ISO 8601
}
type Response = Array<{
organization: string
count: number
repositories: MinimalRepository[]
}>
{
organization: string
count: number
repositories: MinimalRepository[]
}
type PullRequestContributor = { login: string; __typename: string }
type StoredPullRequest = {
number: number
title: string
createdAt: string // ISO 8601
mergedAt: string | null // ISO 8601
closedAt: string | null // ISO 8601
url: string
author: { login: string; __typename: string; avatarUrl: string } | null
repository: { nameWithOwner: string; url: string }
contributors: PullRequestContributor[]
}
type Response = {
repo: string // "owner/name"
since: string // ISO 8601
until: string // ISO 8601
count: number
repoUpdatedAt?: string // ISO 8601
generatedAt: string // ISO 8601
pullRequests: StoredPullRequest[]
}N.B.:
Of course please tell me if you have any question or need any help. As always thank you so much for building and helping us build great things for Logos <3 ! |
dd7e13e to
cada8a5
Compare
|
Hi @jinhojang6 & @JulesFiliot , I hope you both are doing fine! |
|
Hi @nipsysdev , all good thanks! Hope you are doing well. Below are the error logs I found on Vercel: feat/projects_and_repo_pages - the latest branch on the deployment history page
|



Suggestion: What about having a Projects page, where you can explore the different Logos repositories, have some basic info about them and see a timeline of the PRs that were merged & closed.