Skip to content

Conversation

@nipsysdev
Copy link
Collaborator

Suggestion: What about having a Projects page, where you can explore the different Logos repositories, have some basic info about them and see a timeline of the PRs that were merged & closed.

image image

@nipsysdev nipsysdev self-assigned this Aug 14, 2025
@nipsysdev nipsysdev added the enhancement New feature or request label Aug 14, 2025
@vercel
Copy link

vercel bot commented Aug 14, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
contribute-logos-co Error Error Sep 19, 2025 3:41pm

@nipsysdev nipsysdev marked this pull request as draft August 14, 2025 03:48
@nipsysdev
Copy link
Collaborator Author

Sorry guys, I requested a review by mistake (habit).
I vibe coded this PR, so I need to review and clean it up first.

@jinhojang6
Copy link
Contributor

jinhojang6 commented Aug 14, 2025

No problem, and I really love the idea!
Could we add repos at https://github.com/logos-co?
(Update: I read the screenshot wrong. I didn’t see Nomos at first glance, but it was actually there in logos-co)

@nipsysdev
Copy link
Collaborator Author

nipsysdev commented Aug 14, 2025

No problem, and I really love the idea! Could we add repos at https://github.com/logos-co?

I'm not sure if I understood the question correctly, sorry in advance.

It already lists the logos-co repositories:
image
image

It fetches the list of repositories from the Github API, so it should automatically reflect right away if another repo gets created.
The list of the Github orgs to watch is defined in constants/orgs.ts

@jinhojang6
Copy link
Contributor

jinhojang6 commented Aug 14, 2025

@nipsysdev
Ah, my bad, I got confused! I wanted to point out Nomos, but it was actually there under logos-co.

@JulesFiliot
Copy link
Contributor

I agree this is a very nice idea!
Let us know when we can review it.

I'm working on the API right now so we might have overlapping code, let's be careful when we merge everything

@jinhojang6
Copy link
Contributor

jinhojang6 commented Aug 14, 2025

On a different note, I think we could add a Contributors section to README.md, similar to this one: https://github.com/status-im/translate.status.im?tab=readme-ov-file#contributors

What do you think?
@nipsysdev @JulesFiliot

@JulesFiliot
Copy link
Contributor

@nipsysdev
Copy link
Collaborator Author

On a different note, I think we could add a Contributors section to README.md

We would display the contributors from all the Logos repositories or only the contributors of contribute.logos.co?

@jinhojang6
Copy link
Contributor

@nipsysdev It depends on our decision. I think listing all the unique contributors across the Logos repos is idealistic, but we can start by listing contributors for this repo first and then find a way to scale it out later.

@JulesFiliot
Copy link
Contributor

@nipsysdev after discussing it with Jinho we think that it makes more sense to just display the contributors of this repo (contribute.logos.co) in the readme and not all the contributors from Logos. Since the exact purpose of this project is to showcase all the open source contributors throughout the Logos stack we believe that this won't make a lot of sense to add everyone in the readme. What do you think?

@JulesFiliot
Copy link
Contributor

Hey @nipsysdev, we've made many changes to the project since you first opened this PR; a big one related to your work is that we migrated all the api logic to a separated backend to make the frontend fully static. This means that we have to migrate the two routes you created, /api/pull-requests & /api/repositories, to this backend.

I will handle this task - are these two routes still relevant for your work? I would need to do the following changes before shipping your PR:

  • Migrate the API routes to the backend
  • Resolve merge conflicts

I also remember that you wanted to do a review of you code before we ship it, if you still do I think it's better that you do it before I do the migration and conflicts resolve. Would that be ok with you?

@nipsysdev
Copy link
Collaborator Author

Hi guys sorry for the late reply.

@nipsysdev after discussing it with Jinho we think that it makes more sense to just display the contributors of this repo (contribute.logos.co) in the readme and not all the contributors from Logos. Since the exact purpose of this project is to showcase all the open source contributors throughout the Logos stack we believe that this won't make a lot of sense to add everyone in the readme. What do you think?

Makes total sense. I agree!

Hey @nipsysdev, we've made many changes to the project since you first opened this PR; a big one related to your work is that we migrated all the api logic to a separated backend to make the frontend fully static. This means that we have to migrate the two routes you created, /api/pull-requests & /api/repositories, to this backend.

I will handle this task - are these two routes still relevant for your work? I would need to do the following changes before shipping your PR:

  • Migrate the API routes to the backend
  • Resolve merge conflicts

I also remember that you wanted to do a review of you code before we ship it, if you still do I think it's better that you do it before I do the migration and conflicts resolve. Would that be ok with you?

Yes please migrate the API routes to the backend and let me know when the endpoints are ready to be used. I've made myself available to finalize this PR so I can take care of the conflict merging. Once I'm done I'll request a review from you guys yes.

@JulesFiliot
Copy link
Contributor

JulesFiliot commented Sep 5, 2025

@nipsysdev great I'm working on it, let me get back to you when ready!

@JulesFiliot
Copy link
Contributor

Re @nipsysdev, job is done :). I'm just waiting for the infra team to perform the deployment on the dev branch as the automatic ci/cd pipeline is not ready yet (will be soon) so it requires manual deployment.

In the meantime here are the details of the new API routes that will be available:
(For now base URL is: https://dev-admin-acid.logos.co)

  • GET /api/orgs
    • Returns monitored orgs.
    • Response:
{ orgs: string[] }
  • GET /api/projects
    • Returns all orgs’ repos.
    • Response:
type MinimalRepository = {
  id: number
  name: string
  full_name: string
  html_url: string
  description: string | null
  language: string | null
  stargazers_count: number
  forks_count: number
  open_issues_count: number
  updated_at: string // ISO 8601
}

type Response = Array<{
  organization: string
  count: number
  repositories: MinimalRepository[]
}>
  • GET /api/projects/[owner]
    • Path params: owner (org login)
    • Returns one org’s repos and count (empty if not found).
    • Response:
{
  organization: string
  count: number
  repositories: MinimalRepository[]
}
  • GET /api/projects/[owner]/[repo]/pull-requests
    • Path params: owner, repo
    • Returns closed PR timeline for the repo (last 12 months).
    • Response:
type PullRequestContributor = { login: string; __typename: string }

type StoredPullRequest = {
  number: number
  title: string
  createdAt: string // ISO 8601
  mergedAt: string | null // ISO 8601
  closedAt: string | null // ISO 8601
  url: string
  author: { login: string; __typename: string; avatarUrl: string } | null
  repository: { nameWithOwner: string; url: string }
  contributors: PullRequestContributor[]
}

type Response = {
  repo: string // "owner/name"
  since: string // ISO 8601
  until: string // ISO 8601
  count: number
  repoUpdatedAt?: string // ISO 8601
  generatedAt: string // ISO 8601
  pullRequests: StoredPullRequest[]
}

N.B.:

  • Data will be refreshed every 24h.
  • Scope is last 12 months.

Of course please tell me if you have any question or need any help. As always thank you so much for building and helping us build great things for Logos <3 !

@nipsysdev nipsysdev marked this pull request as ready for review September 19, 2025 15:43
@nipsysdev
Copy link
Collaborator Author

Hi @jinhojang6 & @JulesFiliot , I hope you both are doing fine!
Could one of you forward me the latest Vercel deployment error please
I'm not sure what's wrong with it and I get a 404 when trying to access the deployment page on Vercel

@jinhojang6
Copy link
Contributor

jinhojang6 commented Sep 23, 2025

Hi @nipsysdev , all good thanks! Hope you are doing well.

Below are the error logs I found on Vercel:

feat/projects_and_repo_pages - the latest branch on the deployment history page

00:41:28.223 
[Error: Cannot apply unknown utility class: text-white]
00:41:31.780 
 ✓ Compiled successfully in 10.0s
00:41:31.784 
   Linting and checking validity of types ...
00:41:32.141 
 ⚠ TypeScript project references are not fully supported. Attempting to build in incremental mode.
00:41:33.131 
00:41:33.132 
 ⚠ The Next.js plugin was not detected in your ESLint configuration. See https://nextjs.org/docs/app/api-reference/config/eslint#migrating-existing-config
00:41:38.596 
   Collecting page data ...
00:41:39.224 
00:41:39.224 
> Build error occurred
00:41:39.224 
[Error: Page "/[locale]/projects" is missing "generateStaticParams()" so it cannot be used with "output: export" config.]
00:41:39.280 
 ELIFECYCLE  Command failed with exit code 1.
00:41:39.299 
Error: Command "pnpm run build" exited with 1
Screenshot 2025-09-23 at 10 37 05 PM

Base automatically changed from master to develop November 16, 2025 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants