Update API base URL for production environment #14
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
github-project-automation
bot
moved this from In Progress
to Waiting
in Web & User Interfaces
| } | ||
|
|
||
| export function getContributeApiBase() { | ||
| return 'https://dev-admin-acid.logos.co/api' |
There was a problem hiding this comment.
Shouldn't develop/local still point to dev domain?
There was a problem hiding this comment.
@felicio Good point, and I didn't notice it at first.
But this project is purely a frontend that consumes the admin-acid API, so I think using a .env file for the base URL could be unnecessary. (FYI, this project uses static exports without node.js and is deployed by caddy, and the Logos website is using node.js)
Also, the infra team deployed it through Jenkins, and there was no .env file configuration during the initial setup.
But if you think it would be better to manage the base URL through a .env file, let me add one and coordinate with the infra team about the deployment process.
The backend URL was updated so changed it to
'https://admin-acid.logos.co/api'Preview: https://contribute-logos-co-git-update-api-endpoint-acidinfo.vercel.app/en/proposals/