This repository was archived by the owner on Feb 9, 2023. It is now read-only.
Integrate gevent for concurrency #89
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You'd also need to monkey_patch psycopgs to get the benefit from gevent. It is a good idea, but a bit dangerous without a staging environment. |
|
You're totally right Yamac, having a staging environment is crucial to avoid potential dangers. I will convert PR to draft, it can be further considered if we observe througput-wise problems. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request adds gevent support to the codebase. Gevent replaces blocking calls with asynchronous ones for increased throughput.
Moreover, the recommended number of workers for gunicorn is 2 * number of CPUs + 1 (see), but without the knowledge of our CPU count, it has not been modified. (It is 25 right now)