Skip to content

Conversation

ackintosh
Copy link
Owner

@ackintosh ackintosh commented Aug 15, 2018

At the moment, bernard with FlatFileDriver can't notice a new message enqueued while polling.
(refs https://github.com/bernardphp/bernard/blob/3ff88921bea87186d1baffc93708dd7aee4e963e/src/Driver/FlatFile/Driver.php#L102-L113 )

The issue above impacts to Snidel as a delay time which a worker process starts working .

I've filed a PR to resolve the issue but it looks take a while for reviewing/merging it. 👀

As workaround for the issue, this PR add an option which specifies a polling duration(in seconds) for now.

@ackintosh ackintosh changed the title [WIP] Specifying a polling duration of queueing Specifying a polling duration of queueing Aug 15, 2018
@ackintosh
Copy link
Owner Author

This PR taught me a lot, I've published the blog post about what I've learned via this PR. (in Japanese) 📝

declare(ticks=1)を宣言していてもシグナルを処理できない事がある - 暁
https://ackintosh.github.io/blog/2018/08/17/not-all-statements-are-tickable/

@ackintosh ackintosh merged commit ac9c6c8 into master Aug 18, 2018
@ackintosh ackintosh deleted the polling-duration branch August 18, 2018 04:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant