Skip to content

fix: Use css-tree instead of css for parsing /colors#1211

Merged
TheJolman merged 4 commits into
acmcsufoss:mainfrom
TheJolman:fix/csstree
Jan 16, 2026
Merged

fix: Use css-tree instead of css for parsing /colors#1211
TheJolman merged 4 commits into
acmcsufoss:mainfrom
TheJolman:fix/csstree

Conversation

@TheJolman
Copy link
Copy Markdown
Collaborator

@TheJolman TheJolman commented Sep 30, 2025

the npm package css has a depreciated dependency that's generating a warning on npm install, switching to css-tree resolves the issue as a drop in replacement.

npm warn deprecated source-map-resolve@0.6.0: See https://github.com/lydell/source-map-resolve#deprecated

Also introduced a tbody element on the colors page to silence this warning:

node_invalid_placement_ssr: `<tr>` (src/routes/(site)/colors/color.svelte:12:0) cannot be a child of `<table
>` (src/routes/(site)/colors/+page.svelte:25:4). `<table>` only allows these children: `<caption>`, `<colgro
up>`, `<tbody>`, `<thead>`, `<tfoot>`, `<style>`, `<script>`, `<template>`

This can cause content to shift around as the browser repairs the HTML, and will likely result in a `hydrati
on_mismatch` warning.

Reproducing

First, on main:

rm -r node_modules && npm i

Observe depreciation warning.

Then, on this branch:

rm -r node_modules && npm i

Warning should be gone.

@TheJolman TheJolman force-pushed the fix/csstree branch 2 times, most recently from 047995c to 24ab854 Compare January 11, 2026 17:49
@TheJolman TheJolman changed the title fix: Use css-tree instead of css for parsing fix: Use css-tree instead of css for parsing CSS in /colors Jan 11, 2026
@TheJolman TheJolman changed the title fix: Use css-tree instead of css for parsing CSS in /colors fix: Use css-tree instead of css for parsing /colors Jan 11, 2026
@acmcsufoss acmcsufoss deleted a comment from netlify Bot Jan 16, 2026
@TheJolman TheJolman enabled auto-merge (squash) January 16, 2026 21:17
Copy link
Copy Markdown
Collaborator

@dianellasy dianellasy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@TheJolman TheJolman merged commit 6a6c7ae into acmcsufoss:main Jan 16, 2026
3 checks passed
@TheJolman TheJolman deleted the fix/csstree branch April 7, 2026 17:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants