Skip to content

Update author and API version in dns_timeweb.sh#6981

Open
augin wants to merge 1 commit into
acmesh-official:devfrom
augin:dev
Open

Update author and API version in dns_timeweb.sh#6981
augin wants to merge 1 commit into
acmesh-official:devfrom
augin:dev

Conversation

@augin

@augin augin commented May 22, 2026

Copy link
Copy Markdown

the previous script uses an outdated API and is not functional. I offer my working script with API v2

the previous script uses an outdated API and is not functional. I offer my working script with API v2
@github-actions

Copy link
Copy Markdown

Welcome
READ ME !!!!!
Read me !!!!!!
First thing: don't send PR to the master branch, please send to the dev branch instead.
Please read the DNS API Dev Guide.
You MUST pass the DNS-API-Test.
Then reply on this message, otherwise, your code will not be reviewed or merged.
Please also make sure to add/update the usage here: https://github.com/acmesh-official/acme.sh/wiki/dnsapi2
注意: 必须通过了 DNS-API-Test 才会被 review. 无论是修改, 还是新加的 dns api, 都必须确保通过这个测试.

@neilpang

neilpang commented Jul 2, 2026

Copy link
Copy Markdown
Member

This replaces a convention-compliant implementation with a script that breaks several hard rules, so it can't be accepted in this form:

  1. It redefines _debug(), overriding acme.sh's core function for the whole run.
  2. Raw curl — must use _get/_post. echo >&2 — must use _err/_info.
  3. Record id persisted to /tmp/timeweb_*.id — don't store state; look the record up from the API in rm by name + value.
  4. Generic helper names (_load_token, _add_txt_record) — prefix with _timeweb_.
  5. TW_Token must be loaded/saved via _readaccountconf_mutable/_saveaccountconf_mutable; comments must be English; shfmt is failing.
  6. The DNS-API-Test must pass in your fork.

If v1 is really dead (please link an announcement), the right move is to update the existing implementation's endpoints to v2, keeping its structure — not replace the file.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants