Fix building of MV88X3310 with DKMS #22
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jonathan Bennett <[email protected]> I have a card that uses the MV88X3310 chip, and have located the appropriate firmware file and added it to my source directory. DKMS was failing to find and process that firmware file, because the dkms build instructions were changing the current directory before the Makefile had a chance to test for the hdr file's existence. This is a potential workaround, tested to work on CentOS 8.
|
Tested to work on Debian Buster when applied to version 004. |
|
I can confirm this works for me on Manjaro Linux, with the same hardware |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Jonathan Bennett [email protected]
I have a card that uses the MV88X3310 chip, and have located the appropriate firmware file and added it to my source directory. DKMS was failing to find and process that firmware file, because the dkms build instructions were changing the current directory before the Makefile had a chance to test for the hdr file's existence. This is a potential workaround, tested to work on CentOS 8.