Fix using/await using edge cases in for loops - #1432
Merged
Conversation
adams85
force-pushed
the
fix/using-edge-cases
branch
from
March 29, 2026 01:14
d632780 to
22ddd5c
Compare
Member
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, the following
using/await usingedge cases are not handled correctly:for (using of = null;;) {}→ should be accepted (needs lookahead)for (await using of = null;;) {}→ should be acceptedfor (await using of of []) {}→ should be be accepted (however, withoutawait, it's a syntax error!)for (using x in {}) {}→ should be a syntax errorfor (await using x in {}) {}→ should be a syntax errorfor (;;) using x = null,if (true) await using x = null, etc. → should be a syntax errorThis PR implements the necessary changes.