-
-
Notifications
You must be signed in to change notification settings - Fork 144
Add depended on libraries and C++ runtime to link to in pkg-config file #119
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
- Moved AVFFT check: FFMPEG_LIBRARIES might be unset even if all needed FFmpeg libraries were found. - Added an ability to link with VDSP/Accelerate Framework on macOS.
gcc needs libstdc++ and clang needs libc++.
This is needed when the host app is coded in C and has no idea that chromaprint uses C++ internally. |
…e C++ runtime Submitted upstream acoustid/chromaprint#119
@robUx4 Could you post the diff of the pkg-config config on all platforms? The change are kind of hard to review and the diffs would help a lot. |
As the C++ library is only needed for static linking, this should be added only to |
Indeed and static linking is tricky for multiple reasons, it's much better to just include the libraries needed for the particular build in the project's build system. |
On a Linux build, Before:
After:
I agree it my be better in The C++ runtime to use is needed because the library can be used with a C interface. The host app cannot guess what it really needs to link to. When used from C++ code it will pick its own runtime (and should match the one from the library). |
…e C++ runtime Submitted upstream acoustid/chromaprint#119 (cherry picked from commit 7a77242)
When linking statically with chromaprint the app needs to know which libraries to link with. It also needs the C++ runtime if the calling code doesn't have any C++.