GL-3695: Add MySQL version prompt for cs:wizard. #1864
+56
−18
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Copilot wasn't able to review any files in this pull request.
Files not reviewed (4)
- src/Command/CodeStudio/CodeStudioCiCdVariables.php: Language not supported
- src/Command/CodeStudio/CodeStudioWizardCommand.php: Language not supported
- tests/phpunit/src/Commands/CodeStudio/CodeStudioCiCdVariablesTest.php: Language not supported
- tests/phpunit/src/Commands/CodeStudio/CodeStudioWizardCommandTest.php: Language not supported
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1864 +/- ##
============================================
+ Coverage 92.29% 92.31% +0.01%
Complexity 1779 1779
============================================
Files 121 121
Lines 6633 6648 +15
============================================
+ Hits 6122 6137 +15
Misses 511 511 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Try the dev build for this PR: https://acquia-cli.s3.amazonaws.com/build/pr/1864/acli.phar |
PrakharJainS3
suggested changes
Apr 29, 2025
| 'MYSQL_version_5.7' => "5.7", | ||
| 'MYSQL_version_8.0' => "8.0", | ||
| ]; | ||
| $project = $this->io->choice('Select a MySQL version', array_values($mysqlVersions), "5.7"); |
There was a problem hiding this comment.
Default version should be 8.0
There was a problem hiding this comment.
@bemarlan Please address this comment. Rest everything looks good to me.
There was a problem hiding this comment.
This has been updated
PrakharJainS3
approved these changes
Apr 29, 2025
shubham-bansal96
approved these changes
Apr 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please wait to merge & release until Code Studio team gives the ok.
Motivation
Addresses GL-3695
Proposed changes
Adds a prompt for MySQL version to Drupal projects.
Alternatives considered
N/A. This will become a required variable for all Drupal projects, so we should set it upon project setup.
Testing steps
glab auth login --hostname=code.dev.cloudservices.acquia.ioexport GITLAB_HOST=code.dev.cloudservices.acquia.io./bin/acli cs:wizardcs:wizard.