Remove deposit address verification from deposit flow - #1036
Merged
Conversation
The verify-deposit-address verification service is no longer maintained by the Threshold Network and its endpoint (us-central1-keep-prd-210b.cloudfunctions.net/verify-deposit-address) is no longer available. The deposit flow now sends the Bitcoin transaction directly without the verification round-trip. Removes the dead verifyDepositAddress util and useVerifyDepositAddress hook along with their exports.
✅ Deploy Preview for acre-dapp-v1 ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for acre-dapp-testnet ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for acre-dapp ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Apply prettier --write to two files that were already violating the formatting rules on main and were blocking the dapp-format CI job.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Removes the deposit-address verification step from the deposit flow. The flow now sends the Bitcoin transaction directly without first calling the external verification endpoint.
Why
The verification was performed against
https://us-central1-keep-prd-210b.cloudfunctions.net/verify-deposit-address, a service that is no longer maintained by the Threshold Network and whose endpoint is no longer available. With the endpoint gone, every verification call would fail (returningerror/invalid), blocking deposits — so the step has been removed.Changes
DepositBTCModal.tsx: drop theverifyDepositAddresscall and gate; send the BTC transaction directly after resolving.verifyDepositAddressutil anduseVerifyDepositAddresshook, and remove their exports.Note
This removes the client-side check that the SDK-generated deposit address matched the one returned by the Keep service. That check is no longer possible now that the service is gone.