fix: Remove redundant __Ownable_init call in Ownable2StepUpgradeable #936
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
👷 Deploy request for acre-dapp-testnet pending review.Visit the deploys page to approve it
|
|
| Name | Link |
|---|---|
| 🔨 Latest commit | 0962bb0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While working with
Ownable2StepUpgradeable(part of OpenZeppelin Upgradeable contracts), I noticed that the function__Ownable_initdoes not exist. Instead,__Ownable2Step_initis used, which is already correctly called in the code. The line__Ownable_init(_owner);is redundant and can be safely removed to clean up the implementation.This change ensures the code aligns with the intended design of the
Ownable2StepUpgradeablecontract.