Fix subcommand help and refactor argument parsing#3
Conversation
- Remove manual interception of -h/--help in `sid/main.py`. - Update `argparse.ArgumentParser` to use `add_help=True` (default) and `RawDescriptionHelpFormatter`. - Remove manual definition of -h/--help argument. - Update global help description to be more informative. - Fix environment-specific failure in `test_logs_crash_report` by patching `os.path.expanduser`. Co-authored-by: acrollet <101649+acrollet@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
- Remove manual interception of -h/--help in `pippin/main.py`. - Update `argparse.ArgumentParser` to use `add_help=True` (default) and `RawDescriptionHelpFormatter`. - Remove manual definition of -h/--help argument. - Update global help description to reference "Pippin" and be more informative. - Fix environment-specific failure in `tests/test_commands.py` (test_logs_crash_report) by patching `os.path.expanduser`. - Ensure all references are updated to "Pippin" after upstream rename. Co-authored-by: acrollet <101649+acrollet@users.noreply.github.com>
1 participant
This PR refactors the command parsing logic in
sid/main.pyto useargparse's native help generation. This fixes the issue wheresid <subcommand> --helpwould display the global help instead of the subcommand-specific help. It also updates the global help description to be more informative and fixes a flaky test intests/test_commands.pyrelated toos.path.expanduserin different environments.PR created automatically by Jules for task 14590894861178882652 started by @acrollet