chore: port `test/evm/hardhat/chain-adapters` tests to `foundry` by grasphoper · Pull Request #1219 · across-protocol/contracts

grasphoper · 2025-12-12T03:16:50Z

Closes ACX-4890

Signed-off-by: Ihor Farion <ihor@umaproject.org>

linear · 2025-12-12T03:16:53Z

ACX-4890 move smart contract tests from `hardhat` to `foundry`

Signed-off-by: Ihor Farion <ihor@umaproject.org>

grasphoper · 2026-01-07T21:13:13Z

This PR migrates the first of the tests under tests/evm/hardhat/chain-adapters

Let's merge it first to have a common base to use (like the fixture code)

test/evm/foundry/local/Arbitrum_Adapter.t.sol

Signed-off-by: Ihor Farion <ihor@umaproject.org>

* add CLAUDE.md Signed-off-by: Ihor Farion <ihor@umaproject.org> * plan out all tasks Signed-off-by: Ihor Farion <ihor@umaproject.org> * migrate ethereum adapter test Signed-off-by: Ihor Farion <ihor@umaproject.org> * remove Succinct_Adapter from migration tasks Signed-off-by: Ihor Farion <ihor@umaproject.org> * address incorrect constants usage Signed-off-by: Ihor Farion <ihor@umaproject.org> * migrate Arbitrum_SendTokensAdapterTest Signed-off-by: Ihor Farion <ihor@umaproject.org> * migrate Solana_Adapter Signed-off-by: Ihor Farion <ihor@umaproject.org> * port Optimism_Adapter.ts: first draft * improve the testing pattern Signed-off-by: Ihor Farion <ihor@umaproject.org> * port scroll adapter test: impl v0 * improve impl Signed-off-by: Ihor Farion <ihor@umaproject.org> * update TASKS.md with mockCall info Signed-off-by: Ihor Farion <ihor@umaproject.org> * port PolygonZkEVM adapter test Signed-off-by: Ihor Farion <ihor@umaproject.org> * port linea adapter test Signed-off-by: Ihor Farion <ihor@umaproject.org> * update CLAUDE.md Signed-off-by: Ihor Farion <ihor@umaproject.org> * migrate Polygon Adapter tests Signed-off-by: Ihor Farion <ihor@umaproject.org> * consolidate some common functionality Signed-off-by: Ihor Farion <ihor@umaproject.org> * update TASKS Signed-off-by: Ihor Farion <ihor@umaproject.org> * remove tasks Signed-off-by: Ihor Farion <ihor@umaproject.org> --------- Signed-off-by: Ihor Farion <ihor@umaproject.org>

fusmanii · 2026-01-09T16:51:52Z

Changes look good. Missing Succinct_Adapter tests and OP_Adapter.t.sol is missing a test (the "Correctly routes USDC via the configured OP USDC bridge" test from OP_Adapter.ts).

grasphoper · 2026-01-14T01:06:12Z

Changes look good. Missing Succinct_Adapter tests and OP_Adapter.t.sol is missing a test (the "Correctly routes USDC via the configured OP USDC bridge" test from OP_Adapter.ts).

Succinct adapter test should be removed.
Will migrate the OP adapter test fully, agree.

Signed-off-by: Ihor Farion <ihor@umaproject.org>

grasphoper · 2026-01-15T01:46:23Z

generated/constants.json

@fusmanii for some reason this got updated. Is this expected?

looks like master was out of date, created #1242

grasphoper · 2026-01-15T01:46:36Z

broadcast/deployed-addresses.md

Same as https://github.com/across-protocol/contracts/pull/1219/changes#r2692659072

Signed-off-by: Ihor Farion <ihor@umaproject.org>

…itrum-adapter tests Signed-off-by: Ihor Farion <ihor@umaproject.org>

* add Arbitrum_Adapter.t.sol Signed-off-by: Ihor Farion <ihor@umaproject.org> * refactor Signed-off-by: Ihor Farion <ihor@umaproject.org> * add more asserts to the new test Signed-off-by: Ihor Farion <ihor@umaproject.org> * address incorrect constants usage Signed-off-by: Ihor Farion <ihor@umaproject.org> * chore: move tests from `chain-adapter` folder (#1233) * add CLAUDE.md Signed-off-by: Ihor Farion <ihor@umaproject.org> * plan out all tasks Signed-off-by: Ihor Farion <ihor@umaproject.org> * migrate ethereum adapter test Signed-off-by: Ihor Farion <ihor@umaproject.org> * remove Succinct_Adapter from migration tasks Signed-off-by: Ihor Farion <ihor@umaproject.org> * address incorrect constants usage Signed-off-by: Ihor Farion <ihor@umaproject.org> * migrate Arbitrum_SendTokensAdapterTest Signed-off-by: Ihor Farion <ihor@umaproject.org> * migrate Solana_Adapter Signed-off-by: Ihor Farion <ihor@umaproject.org> * port Optimism_Adapter.ts: first draft * improve the testing pattern Signed-off-by: Ihor Farion <ihor@umaproject.org> * port scroll adapter test: impl v0 * improve impl Signed-off-by: Ihor Farion <ihor@umaproject.org> * update TASKS.md with mockCall info Signed-off-by: Ihor Farion <ihor@umaproject.org> * port PolygonZkEVM adapter test Signed-off-by: Ihor Farion <ihor@umaproject.org> * port linea adapter test Signed-off-by: Ihor Farion <ihor@umaproject.org> * update CLAUDE.md Signed-off-by: Ihor Farion <ihor@umaproject.org> * migrate Polygon Adapter tests Signed-off-by: Ihor Farion <ihor@umaproject.org> * consolidate some common functionality Signed-off-by: Ihor Farion <ihor@umaproject.org> * update TASKS Signed-off-by: Ihor Farion <ihor@umaproject.org> * remove tasks Signed-off-by: Ihor Farion <ihor@umaproject.org> --------- Signed-off-by: Ihor Farion <ihor@umaproject.org> * port OP_Adapter test Signed-off-by: Ihor Farion <ihor@umaproject.org> * remove ported hardhat tests Signed-off-by: Ihor Farion <ihor@umaproject.org> * move chain adapter tests to chain-adapters/ Signed-off-by: Ihor Farion <ihor@umaproject.org> * fix import paths for chain adapter tests + add missing asserts to arbitrum-adapter tests Signed-off-by: Ihor Farion <ihor@umaproject.org> * complete Arbitrum_SendTokensAdapter test --------- Signed-off-by: Ihor Farion <ihor@umaproject.org>

add Arbitrum_Adapter.t.sol

4a66758

Signed-off-by: Ihor Farion <ihor@umaproject.org>

grasphoper added 2 commits December 11, 2025 19:34

refactor

d565f07

Signed-off-by: Ihor Farion <ihor@umaproject.org>

add more asserts to the new test

4ae0e6d

Signed-off-by: Ihor Farion <ihor@umaproject.org>

grasphoper marked this pull request as ready for review January 7, 2026 21:13

grasphoper requested review from bmzig, mrice32, nicholaspai and pxrl as code owners January 7, 2026 21:13

grasphoper requested review from fusmanii and tbwebb22 January 7, 2026 21:13

Merge branch 'master' into if/move-tests-to-foundry

62d70a0

tbwebb22 reviewed Jan 7, 2026

View reviewed changes

test/evm/foundry/local/Arbitrum_Adapter.t.sol Outdated Show resolved Hide resolved

address incorrect constants usage

46ab8ab

Signed-off-by: Ihor Farion <ihor@umaproject.org>

fusmanii previously approved these changes Jan 8, 2026

View reviewed changes

tbwebb22 self-requested a review January 8, 2026 19:43

tbwebb22 previously approved these changes Jan 8, 2026

View reviewed changes

grasphoper dismissed stale reviews from tbwebb22 and fusmanii via e152ecb January 9, 2026 07:12

grasphoper requested review from fusmanii and tbwebb22 January 14, 2026 01:05

grasphoper changed the title ~~chore: port hardhat tests to foundry~~ chore: port test/evm/hardhat/chain-adapters tests to foundry Jan 15, 2026

grasphoper added 3 commits January 14, 2026 17:21

Merge branch 'master' into if/move-tests-to-foundry

3e6d2e3

port OP_Adapter test

c408962

Signed-off-by: Ihor Farion <ihor@umaproject.org>

remove ported hardhat tests

f57a328

Signed-off-by: Ihor Farion <ihor@umaproject.org>

grasphoper commented Jan 15, 2026

View reviewed changes

broadcast/deployed-addresses.md

Copy link

Contributor Author

grasphoper Jan 15, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as https://github.com/across-protocol/contracts/pull/1219/changes#r2692659072

tbwebb22 previously approved these changes Jan 15, 2026

View reviewed changes

move chain adapter tests to chain-adapters/

cee543d

Signed-off-by: Ihor Farion <ihor@umaproject.org>

grasphoper dismissed tbwebb22’s stale review via cee543d January 15, 2026 01:50

fix import paths for chain adapter tests + add missing asserts to arb…

9ff3984

…itrum-adapter tests Signed-off-by: Ihor Farion <ihor@umaproject.org>

grasphoper marked this pull request as draft January 15, 2026 02:11

complete Arbitrum_SendTokensAdapter test

7594aa7

grasphoper marked this pull request as ready for review January 15, 2026 04:31

grasphoper requested a review from tbwebb22 January 15, 2026 04:32

fusmanii approved these changes Jan 15, 2026

View reviewed changes

grasphoper merged commit 75a74ba into master Jan 15, 2026
13 checks passed

grasphoper deleted the if/move-tests-to-foundry branch January 15, 2026 21:29

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Comments

chore: port `test/evm/hardhat/chain-adapters` tests to `foundry`#1219

chore: port `test/evm/hardhat/chain-adapters` tests to `foundry`#1219
grasphoper merged 12 commits intomasterfrom
if/move-tests-to-foundry

grasphoper commented Dec 12, 2025

Uh oh!

linear bot commented Dec 12, 2025

Uh oh!

grasphoper commented Jan 7, 2026

Uh oh!

Uh oh!

fusmanii commented Jan 9, 2026

Uh oh!

grasphoper commented Jan 14, 2026

Uh oh!

grasphoper Jan 15, 2026

Uh oh!

fusmanii Jan 15, 2026

Uh oh!

grasphoper Jan 15, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Comments

Conversation

grasphoper commented Dec 12, 2025

Uh oh!

linear bot commented Dec 12, 2025

Uh oh!

grasphoper commented Jan 7, 2026

Uh oh!

Uh oh!

fusmanii commented Jan 9, 2026

Uh oh!

grasphoper commented Jan 14, 2026

Uh oh!

grasphoper Jan 15, 2026

Choose a reason for hiding this comment

Uh oh!

fusmanii Jan 15, 2026

Choose a reason for hiding this comment

Uh oh!

grasphoper Jan 15, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants