chore: port hardhat tests to foundry
#1219
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ihor Farion <[email protected]>
Signed-off-by: Ihor Farion <[email protected]>
Signed-off-by: Ihor Farion <[email protected]>
Contributor
Author
|
This PR migrates the first of the tests under Let's merge it first to have a common base to use (like the fixture code) |
grasphoper
requested review from
bmzig,
mrice32,
nicholaspai and
pxrl
as code owners
tbwebb22
reviewed
Jan 7, 2026
Signed-off-by: Ihor Farion <[email protected]>
fusmanii
previously approved these changes
Jan 8, 2026
tbwebb22
previously approved these changes
Jan 8, 2026
* add CLAUDE.md Signed-off-by: Ihor Farion <[email protected]> * plan out all tasks Signed-off-by: Ihor Farion <[email protected]> * migrate ethereum adapter test Signed-off-by: Ihor Farion <[email protected]> * remove Succinct_Adapter from migration tasks Signed-off-by: Ihor Farion <[email protected]> * address incorrect constants usage Signed-off-by: Ihor Farion <[email protected]> * migrate Arbitrum_SendTokensAdapterTest Signed-off-by: Ihor Farion <[email protected]> * migrate Solana_Adapter Signed-off-by: Ihor Farion <[email protected]> * port Optimism_Adapter.ts: first draft * improve the testing pattern Signed-off-by: Ihor Farion <[email protected]> * port scroll adapter test: impl v0 * improve impl Signed-off-by: Ihor Farion <[email protected]> * update TASKS.md with mockCall info Signed-off-by: Ihor Farion <[email protected]> * port PolygonZkEVM adapter test Signed-off-by: Ihor Farion <[email protected]> * port linea adapter test Signed-off-by: Ihor Farion <[email protected]> * update CLAUDE.md Signed-off-by: Ihor Farion <[email protected]> * migrate Polygon Adapter tests Signed-off-by: Ihor Farion <[email protected]> * consolidate some common functionality Signed-off-by: Ihor Farion <[email protected]> * update TASKS Signed-off-by: Ihor Farion <[email protected]> * remove tasks Signed-off-by: Ihor Farion <[email protected]> --------- Signed-off-by: Ihor Farion <[email protected]>
Contributor
|
Changes look good. Missing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes ACX-4890