Skip to content

Conversation

@fusmanii
Copy link
Contributor

@fusmanii fusmanii commented Dec 10, 2025

Generating typechain types using foundry and saving it in a separate folder called typechain-types so that we can easily migrate. This reduces our dependency on hardhat

@socket-security
Copy link

socket-security bot commented Dec 10, 2025

Warning

Review the following alerts detected in dependencies.

According to your organization's Security Policy, it is recommended to resolve "Warn" alerts. Learn more about Socket for GitHub.

Action Severity Alert  (click "▶" to expand/collapse)
Warn Critical
Critical CVE: TimelockController vulnerability in OpenZeppelin Contracts in npm @openzeppelin/contracts

CVE: GHSA-fg47-3c2x-m2wr TimelockController vulnerability in OpenZeppelin Contracts (CRITICAL)

Affected versions: >= 4.0.0 < 4.3.1; >= 3.3.0 < 3.4.2

Patched version: 4.3.1

From: ?npm/@uma/[email protected]npm/@openzeppelin/[email protected]

ℹ Read more on: This package | This alert | What is a critical CVE?

Next steps: Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at [email protected].

Suggestion: Remove or replace dependencies that include known critical CVEs. Consumers can use dependency overrides or npm audit fix --force to remove vulnerable dependencies.

Mark the package as acceptable risk. To ignore this alert only in this pull request, reply with the comment @SocketSecurity ignore npm/@openzeppelin/[email protected]. You can also ignore all packages with @SocketSecurity ignore-all. To ignore an alert for all future pull requests, use Socket's Dashboard to change the triage state of this alert.

Warn Critical
Critical CVE: UUPSUpgradeable vulnerability in npm @openzeppelin/contracts

CVE: GHSA-5vp3-v4hc-gx76 UUPSUpgradeable vulnerability in @openzeppelin/contracts (CRITICAL)

Affected versions: >= 4.1.0 < 4.3.2

Patched version: 4.3.2

From: ?npm/@uma/[email protected]npm/@openzeppelin/[email protected]

ℹ Read more on: This package | This alert | What is a critical CVE?

Next steps: Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at [email protected].

Suggestion: Remove or replace dependencies that include known critical CVEs. Consumers can use dependency overrides or npm audit fix --force to remove vulnerable dependencies.

Mark the package as acceptable risk. To ignore this alert only in this pull request, reply with the comment @SocketSecurity ignore npm/@openzeppelin/[email protected]. You can also ignore all packages with @SocketSecurity ignore-all. To ignore an alert for all future pull requests, use Socket's Dashboard to change the triage state of this alert.

Warn High
Git dependency: npm @matterlabs/hardhat-zksync-telemetry depends on git+https://github.com/matter-labs/zksync-telemetry-js.git#2fd9edbe6b9a5e0c2caeda4b04dd5631d7546a11

Dependency: @matterlabs/zksync-telemetry-js@git+https://github.com/matter-labs/zksync-telemetry-js.git#2fd9edbe6b9a5e0c2caeda4b04dd5631d7546a11

Location: Package overview

From: ?npm/@matterlabs/[email protected]npm/@matterlabs/[email protected]npm/@matterlabs/[email protected]

ℹ Read more on: This package | This alert | What are git dependencies?

Next steps: Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at [email protected].

Suggestion: Publish the git dependency to a public or private package repository and consume it from there.

Mark the package as acceptable risk. To ignore this alert only in this pull request, reply with the comment @SocketSecurity ignore npm/@matterlabs/[email protected]. You can also ignore all packages with @SocketSecurity ignore-all. To ignore an alert for all future pull requests, use Socket's Dashboard to change the triage state of this alert.

View full report

Signed-off-by: Faisal Usmani <[email protected]>
Signed-off-by: Faisal Usmani <[email protected]>
Signed-off-by: Faisal Usmani <[email protected]>
@fusmanii fusmanii marked this pull request as ready for review December 10, 2025 22:02
Signed-off-by: Faisal Usmani <[email protected]>
Signed-off-by: Faisal Usmani <[email protected]>
Signed-off-by: Faisal Usmani <[email protected]>
Signed-off-by: Faisal Usmani <[email protected]>
Signed-off-by: Faisal Usmani <[email protected]>
@fusmanii fusmanii marked this pull request as draft December 11, 2025 21:09
Signed-off-by: Faisal Usmani <[email protected]>
Signed-off-by: Faisal Usmani <[email protected]>
Signed-off-by: Faisal Usmani <[email protected]>
Signed-off-by: Faisal Usmani <[email protected]>
Signed-off-by: Faisal Usmani <[email protected]>
Signed-off-by: Faisal Usmani <[email protected]>
@fusmanii fusmanii marked this pull request as ready for review December 17, 2025 21:31
Signed-off-by: Faisal Usmani <[email protected]>
Signed-off-by: Faisal Usmani <[email protected]>
Signed-off-by: Faisal Usmani <[email protected]>
Signed-off-by: Faisal Usmani <[email protected]>
Signed-off-by: Faisal Usmani <[email protected]>
@tbwebb22 tbwebb22 self-requested a review December 18, 2025 18:24
tbwebb22
tbwebb22 previously approved these changes Dec 18, 2025
@grasphoper grasphoper added the do not merge do not merge label Dec 19, 2025
@grasphoper
Copy link
Contributor

Let's not merge it until we're certain that all consumer repos are compatible. Also, as discussed in Slack, we might want to remove typechain generation from the conatracts repo altogether and let consumers generate types from compilation artifacts exported from this repo

Signed-off-by: Faisal Usmani <[email protected]>
Signed-off-by: Faisal Usmani <[email protected]>
Signed-off-by: Faisal Usmani <[email protected]>
Signed-off-by: Faisal Usmani <[email protected]>
Signed-off-by: Faisal Usmani <[email protected]>
Signed-off-by: Faisal Usmani <[email protected]>
Signed-off-by: Faisal Usmani <[email protected]>
Signed-off-by: Faisal Usmani <[email protected]>
@socket-security
Copy link

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff Package Supply Chain
Security
Vulnerability Quality Maintenance License
Added@​matterlabs/​zksync-contracts@​0.2.4751003688100
Added@​pinata/​sdk@​2.1.09910010050100
Added@​scroll-tech/​contracts@​0.1.0941005585100
Added@​openzeppelin/​foundry-upgrades@​0.4.0591009287100
Updated@​uma/​common@​2.34.0 ⏵ 2.37.366 -110077 -185 +270
Added@​matterlabs/​hardhat-zksync-deploy@​0.6.3871006987100
Added@​matterlabs/​hardhat-zksync-upgradable@​0.1.0771007291100
Added@​across-protocol/​constants@​3.1.8880100749970
Added@​uma/​contracts-node@​0.4.17751001008570
Added@​types/​yargs@​17.0.331001007587100
Added@​types/​chai@​4.3.51001007783100
Added@​types/​mocha@​9.1.01001007780100
Added@​coral-xyz/​anchor@​0.31.1981007984100
Added@​typechain/​ethers-v5@​11.0.0991009379100
Added@​defi-wonderland/​smock@​2.3.4811009980100
Added@​types/​node@​12.20.461001008096100
Added@​ethersproject/​abstract-signer@​5.7.01001008181100
Added@​ethersproject/​abstract-provider@​5.7.01001008781100
Added@​ethersproject/​bignumber@​5.7.01001008481100
Added@​nomiclabs/​hardhat-waffle@​2.0.3971009282100
Added@​solana-developers/​helpers@​2.5.59810010082100
Added@​eth-optimism/​contracts@​0.5.40991001008270
Added@​solana-program/​address-lookup-table@​0.7.0981008384100
Added@​nomiclabs/​hardhat-ethers@​2.2.310010010083100
Added@​solana/​spl-token@​0.4.89910010083100
Added@​codama/​nodes-from-anchor@​1.2.0851008494100
Added@​solana-program/​token@​0.5.11001008588100
Added@​matterlabs/​hardhat-zksync-solc@​1.4.09210010085100
Added@​matterlabs/​hardhat-zksync-verify@​1.9.09210010086100
Added@​solana/​web3.js@​1.98.29510010088100
Added@​codama/​renderers-js@​1.2.14901008995100
Added@​openzeppelin/​hardhat-upgrades@​1.22.09910010089100
See 9 more rows in the dashboard

View full report

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

do not merge do not merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants