Skip to content

chore: Use local getNodeUrl() #1230

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
pxrl wants to merge 20 commits into
base: master
Choose a base branch
from
Open

chore: Use local getNodeUrl() #1230

pxrl wants to merge 20 commits into from

Conversation

@pxrl
Copy link
Contributor

@pxrl pxrl commented Jan 6, 2026

Drops an additional unnecessary use of @uma/common.

tbwebb22 and others added 7 commits December 17, 2025 09:03
@pxrl pxrl changed the title refactor(scripts): Use local getNodeUrl() chore: Use local getNodeUrl() and getMnemonic() Jan 6, 2026
@pxrl pxrl changed the title chore: Use local getNodeUrl() and getMnemonic() chore: Use local getNodeUrl() Jan 6, 2026
@pxrl pxrl changed the base branch from master to taylor/migrate-tasks January 9, 2026 10:29
@pxrl pxrl changed the base branch from taylor/migrate-tasks to master January 9, 2026 10:30
@pxrl pxrl changed the base branch from master to taylor/migrate-tasks January 9, 2026 10:30
@pxrl pxrl changed the base branch from taylor/migrate-tasks to master January 9, 2026 11:04
@pxrl pxrl changed the base branch from master to taylor/migrate-tasks January 9, 2026 11:04
@pxrl pxrl changed the base branch from taylor/migrate-tasks to master January 9, 2026 11:04
@pxrl pxrl added the do not merge do not merge label Jan 9, 2026
@pxrl
Copy link
Contributor Author

pxrl commented Jan 9, 2026

To be merged after @tbwebb22's PR #1226. This PR includes taylor's branch, but github seems totally confused about how to display the diff, and it's making this change look much bigger than it really is.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mrice32 mrice32 Awaiting requested review from mrice32 mrice32 is a code owner

@nicholaspai nicholaspai Awaiting requested review from nicholaspai nicholaspai is a code owner

@chrismaree chrismaree Awaiting requested review from chrismaree chrismaree is a code owner

@Reinis-FRP Reinis-FRP Awaiting requested review from Reinis-FRP Reinis-FRP is a code owner

@md0x md0x Awaiting requested review from md0x md0x is a code owner

@bmzig bmzig Awaiting requested review from bmzig bmzig is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

do not merge do not merge

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@pxrl @tbwebb22