chore: Remove leading number from foundry scripts#1246
Merged
Conversation
Signed-off-by: Faisal Usmani <faisal.of.usmani@gmail.com>
Signed-off-by: Faisal Usmani <faisal.of.usmani@gmail.com>
fusmanii
requested review from
bmzig,
mrice32,
nicholaspai and
pxrl
as code owners
Signed-off-by: Faisal Usmani <faisal.of.usmani@gmail.com>
Contributor
|
@fusmanii meta, but I noticed that the commit hook is really persistent at adding perceived updated deployments. Your PR here seems to be impacted by the same. There seems to be some persistent state and I haven't figured out where it is; this can cause issues when swapping branches (etc) and generally seems like it could be a source of nasty merge conflicts. Do you know how we can make it a bit more graceful? |
Contributor
Author
fusmanii
commented
Jan 19, 2026
| "address": "0x89004ea51bac007fec55976967135b2aa6e838d4", | ||
| "block_number": 23977771, | ||
| "transaction_hash": "0x0b05b7bc28e6d8ea9d9c135bbada908dd2b971e8428054a62598c2cbf9e24baa" | ||
| "PermissionSplitterProxy": { |
Contributor
Author
There was a problem hiding this comment.
These are just being re-ordered
fusmanii
commented
Jan 19, 2026
| }, | ||
| "SponsoredCCTPDstPeriphery": { | ||
| "address": "0x1c709fd0db6a6b877ddb19ae3d485b7b4add879f", | ||
| "address": "0x039d62c549f27ead0eb9b567d8776289e5020583", |
Contributor
Author
There was a problem hiding this comment.
The address here is changing because there is a collision on DonationBox name and after the script renaming the other donation box address is being picked up. I have follow up work to fix this issue
grasphoper
approved these changes
Jan 19, 2026
fusmanii
deleted the
faisal/acp-21-remove-leading-number-from-foundry-scripts
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.