improve(tasks): Auto deposit for new LP tokens #901
+30
−11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When adding new deposit routes, if the LP token for the given L1 token does not yet exist, create the LP token and atomically deposit and burn a single unit. This prevents the HubPool from ever having a 0 balance of the l1 token, protecting against a known issue. It's been on the todo list to automate this for a while, but it hasn't been prioritised because adding LP tokens is quite infrequent. Atomic deposit-and-burn was done manually last time (0x566087fbaa74a32ec94bf4ba58c1451bf916991b686c0895245f726339b1725d), but it's preferable to automate this as much as possible to remove the human element.
nicholaspai
previously approved these changes
Feb 21, 2025
pxrl
commented
Feb 21, 2025
pxrl
commented
Feb 21, 2025
pxrl
changed the title
pxrl
commented
Feb 22, 2025
| ); | ||
| const minDeposit = "1"; | ||
| callData.push(hubPool.interface.encodeFunctionData("addLiquidity", [l1Token, minDeposit])); |
There was a problem hiding this comment.
Note this implies that the owner address must have made an l1Token approval for the HubPool in advance of executing this. That should be prepended before this HubPool multicall.
For testnet definitions.
nicholaspai
reviewed
Feb 27, 2025
|
|
||
| const chainPadding = enabledChainIds[enabledChainIds.length - 1].toString().length; | ||
| const formatChainId = (chainId: number): string => chainId.toString().padStart(chainPadding, " "); | ||
| const enabledChainIds = (hubChainId: number) => { |
There was a problem hiding this comment.
We should probably read this from a config store to be safe, just a comment
There was a problem hiding this comment.
There's a subtle bootstrapping problem with that - it doesn't work for new chains because the entries don't exist at the point where we're using this script to generate the routes :(
nicholaspai
previously approved these changes
Feb 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When adding new deposit routes, if the LP token for the given L1 token does not yet exist, create the LP token and atomically deposit and burn a single unit. This prevents the HubPool from ever having a 0 balance of the l1 token, protecting against a known issue.
It's been on the todo list to automate this for a while, but it hasn't been prioritised because adding LP tokens is quite infrequent. Atomic deposit-and-burn was done manually last time (0x566087fbaa74a32ec94bf4ba58c1451bf916991b686c0895245f726339b1725d), but it's preferable to automate this as much as possible to remove the human element.