improve: type extension recognition for HardhatRuntimeEnvironment
#934
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem:
deployments, ethers, getChainId
don't get recognized by Typescript language server and give red squigglies, which makes hre hard to work with. This happens in multiple places in the contracts repo.Solution:
Add
tasks/
anddeploy/
toinclude
section intsconfig.json
. https://www.typescriptlang.org/tsconfig/#includeIt makes the language server "include" these folders and resolve types properly for them. This shouldn't have any side effects. The only one I can guess is npm package, which should be fixable by
.npmignore
. But I checked theyarn pack
output, and thetasks/
anddeploy/
folders stayed similar to our current npm package.Edit: after looking at CI output, I realize that I'd have to fix a lot of TS linter errors before this can go in. Do you guys think it's worth doing? 😄