Skip to content

fix(svm): N-03 use consistent variable names in the instruction constraint #962

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: solana-march-audit-2
Choose a base branch
from
Open

fix(svm): N-03 use consistent variable names in the instruction constraint #962

wants to merge 3 commits into from

Conversation

Reinis-FRP
Copy link
Contributor

OZ identified following issue:

The fill_relay function accepts a _relay_hash parameter but the FillRelay struct constraint calls it relay_hash (without the leading underscore).

To avoid confusion, consider maintaining consistent variable names when using the instruction constraint.

This PR addresses the issue by using the same variable names when using the instruction constraint.

Reinis-FRP and others added 2 commits April 17, 2025 13:20
@Reinis-FRP
fix(svm): pin rust toolchain for solana (#960)
296ff03 
* fix(svm): pin rust toolchain for solana

Signed-off-by: Reinis Martinsons <[email protected]>

* fix: add local toolchain

Signed-off-by: Reinis Martinsons <[email protected]>

* fix: add rustfmt to nightly

Signed-off-by: Reinis Martinsons <[email protected]>

* fix: pin nightly in lint scripts

Signed-off-by: Reinis Martinsons <[email protected]>

---------

Signed-off-by: Reinis Martinsons <[email protected]>
@Reinis-FRP
fix(svm): N-03 use consistent variable names in the instruction const…
e2b0bb3 
…raint

Signed-off-by: Reinis Martinsons <[email protected]>
@linear Linear
Copy link

linear bot commented Apr 17, 2025

ACX-4025 N-03 Naming Inconsistency

md0x
md0x approved these changes Apr 18, 2025
View reviewed changes
Copy link
Contributor

@md0x md0x left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@md0x md0x md0x approved these changes

@mrice32 mrice32 Awaiting requested review from mrice32 mrice32 is a code owner

@nicholaspai nicholaspai Awaiting requested review from nicholaspai nicholaspai is a code owner

@chrismaree chrismaree Awaiting requested review from chrismaree chrismaree is a code owner

@pxrl pxrl Awaiting requested review from pxrl

@bmzig bmzig Awaiting requested review from bmzig

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Reinis-FRP @md0x