Skip to content

fix(svm): N-02 clarify documentation #963

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: solana-march-audit-2
Choose a base branch
from

Conversation

Reinis-FRP
Copy link
Contributor

OZ identified following issue:

Throughout the codebase, multiple instances of misleading documentation were identified:

  • Line 68 of nativeDeposit.ts states that the vault ATA is created when the route is enabled. However, route enabling has been removed in pull request #939.
  • Line 1 of createVault.ts says that the script is used by the chain admin, but it can be used by anyone to create the vault PDA when necessary.

Consider correcting the aforementioned comments to improve the overall clarity and readability of the codebase.

This PR addresses the issue by clarifying the comments in the scripts.

Signed-off-by: Reinis Martinsons <[email protected]>
Copy link

linear bot commented Apr 17, 2025

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants