Skip to content

fix(svm): N-01 remove v3 from remaining functions and comments #964

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: solana-march-audit-2
Choose a base branch
from

Conversation

Reinis-FRP
Copy link
Contributor

OZ identified following issue:

Pull request #861 renames several functions and types to remove the "V3" qualifier from the Solana spoke codebase. However, the renaming is incomplete:

Consider updating all functions and comments that mention "V3" for consistency with the rest of the code base.

This PR addresses the issue by removing the mention of "V3" from the rest of the SVM code base.
The only exception to this is handle_v3_across_message function and its related structs and constants as "V3" notion is also kept in the EVM where AcrossMessageHandler still has the handleV3AcrossMessage in its interface.

Copy link

linear bot commented Apr 17, 2025

Copy link
Contributor

@md0x md0x left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants