Skip to content

chore(ZkStack_Adapter): Remove unused canonicalTxHash #982

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 30, 2025
Merged

chore(ZkStack_Adapter): Remove unused canonicalTxHash #982

merged 1 commit into from
Apr 30, 2025

Conversation

pxrl
Copy link
Contributor

@pxrl pxrl commented Apr 29, 2025 •
edited
Loading

This variable is no longer used. Removing it addresses a warning being emitted by solc.

Warning: Unused local variable.
   --> contracts/chain-adapters/ZkStack_CustomGasToken_Adapter.sol:152:9:
    |
152 |         bytes32 canonicalTxHash = BRIDGE_HUB.requestL2TransactionDirect(
    |         ^^^^^^^^^^^^^^^^^^^^^^^

@pxrl
chore(ZkStack_Adapter): Remove unused canonicalTxHash
1a23663 
This variable is no longer used. Removing it addresses a warning being
emitted by solc.
@pxrl pxrl merged commit f5e1c22 into audit-zkstack-usdc Apr 30, 2025
9 checks passed
@pxrl pxrl deleted the pxrl/canonicalTxHash branch April 30, 2025 09:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nicholaspai nicholaspai nicholaspai approved these changes

@mrice32 mrice32 Awaiting requested review from mrice32

@bmzig bmzig Awaiting requested review from bmzig

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pxrl @nicholaspai