-
Notifications
You must be signed in to change notification settings - Fork 50
feat: relayer authentication verification method #1320
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
dylanuma
wants to merge
1
commit into
epic/relayer-config
Choose a base branch
from
dylan/acx-3502-api-implement-relayer-authentication-verification2
base: epic/relayer-config
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,67 @@ | ||
import { utils } from 'ethers'; | ||
import { getProvider } from '@/utils/provider'; | ||
|
||
/** | ||
* Verify a relayer's configuration update signature and nonce | ||
* @param configPayload The configuration update payload | ||
* @param signature The signature provided by the relayer | ||
* @param nonce The nonce value to prevent replay attacks | ||
* @throws Error if signature is invalid or nonce has been used | ||
*/ | ||
export async function verifyRelayerSignature( | ||
configPayload: Record<string, any>, | ||
signature: string, | ||
nonce: number | ||
): Promise<void> { | ||
try { | ||
// Verify nonce hasn't been used before | ||
if (await hasNonceBeenUsed(nonce)) { | ||
throw new Error('Nonce has already been used'); | ||
} | ||
|
||
// Add nonce to payload before verifying | ||
const payloadWithNonce = { | ||
...configPayload, | ||
nonce | ||
}; | ||
|
||
// Convert payload to string and hash it | ||
const payloadStr = JSON.stringify(payloadWithNonce); | ||
const messageHash = utils.keccak256(utils.toUtf8Bytes(payloadStr)); | ||
|
||
// Create signable message | ||
const prefixedMessage = utils.arrayify(messageHash); | ||
|
||
// Recover the address that signed the message | ||
const recoveredAddress = utils.verifyMessage(prefixedMessage, signature); | ||
const checksumAddress = utils.getAddress(recoveredAddress); | ||
|
||
// Verify signer is an authorized relayer | ||
if (!await isAuthorizedRelayer(checksumAddress)) { | ||
throw new Error('Signer is not an authorized relayer'); | ||
} | ||
|
||
// Store nonce as used | ||
await storeUsedNonce(nonce); | ||
|
||
} catch (error) { | ||
console.error('Error verifying relayer signature:', error); | ||
throw error; | ||
} | ||
} | ||
|
||
// Helper functions that would need to be implemented: | ||
async function hasNonceBeenUsed(nonce: number): Promise<boolean> { | ||
// Check if nonce exists in storage | ||
throw new Error('Not implemented'); | ||
} | ||
|
||
async function isAuthorizedRelayer(address: string): Promise<boolean> { | ||
// Check if address is in authorized relayer list | ||
throw new Error('Not implemented'); | ||
} | ||
|
||
async function storeUsedNonce(nonce: number): Promise<void> { | ||
// Store nonce in persistent storage | ||
throw new Error('Not implemented'); | ||
} |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can do:
ethers.utils.verifyMessage(message, signature);