feat: add api tests for deposits #261
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daywiss
force-pushed
the
david/acx-3985-add-e2e-tests-for-deposits-endpoint
branch
2 times, most recently
from
c840939 to
ec9a6e9
Compare
daywiss
requested review from
mrice32,
nicholaspai,
amateima,
melisaguevara and
james-a-morris
as code owners
Signed-off-by: david <[email protected]>
daywiss
force-pushed
the
david/acx-3985-add-e2e-tests-for-deposits-endpoint
branch
from
ec9a6e9 to
77ee38b
Compare
There was a problem hiding this comment.
Just making sure: do we want to reference an of the already created logic in the SDK/relayer for mocking events
Signed-off-by: david <[email protected]>
amateima
approved these changes
Apr 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
motivation
we want e2e tests for api deposit endpoints
changes
This adds basic tests for the deposits service, which is what directly feeds the api. The api endpoint itself is not tested since most of that is infrastructure connecting the service class.