feat: add deposit status and router test #267
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: david <[email protected]>
daywiss
force-pushed
the
david/acx-4038-add-e2e-tests-for-http-endpoints
branch
from
70c6519 to
e2e44b3
Compare
daywiss
requested review from
mrice32,
nicholaspai,
amateima,
melisaguevara and
james-a-morris
as code owners
daywiss
changed the title
| describe("Express App Tests with Deposits Endpoint", () => { | ||
| let app: express.Express; | ||
| let dataSource: DataSource; | ||
| let redis: Redis; |
There was a problem hiding this comment.
OOC what redis instance is this targeting?
There was a problem hiding this comment.
I think it targets the Redis instance part of the testing docker-compose file
amateima
approved these changes
Apr 28, 2025
| describe("Express App Tests with Deposits Endpoint", () => { | ||
| let app: express.Express; | ||
| let dataSource: DataSource; | ||
| let redis: Redis; |
There was a problem hiding this comment.
I think it targets the Redis instance part of the testing docker-compose file
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
motivation
add more api tests
changes
add deposit status test as well as express endpoint testing