Skip to content

improve: rename return fields to match deposit status #270

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: stage
Choose a base branch
from

Conversation

daywiss
Copy link
Contributor

@daywiss daywiss commented Apr 24, 2025

motivation

we want to see return types the same as the deposit status return type

changes

Only a couple fields needed to change in the other endpoints

Copy link

linear bot commented Apr 24, 2025

Copy link
Contributor

@amateima amateima left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved, but this is a breaking change for the FE. I need to prepare the Transactions Page for the new fields names

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants