feat: Handle cases where a deposit's inputToken and originChain cannot be mapped to a PoolRebalanceRoute #2177
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t be mapped to a PoolRebalanceRoute Relayer: - Refuses to fill such deposits Dataworker: - Does not let such deposits affect bundle LP fees and running balance calculations
pxrl
reviewed
Apr 9, 2025
nicholaspai
commented
Apr 14, 2025
nicholaspai
commented
Apr 14, 2025
nicholaspai
commented
Apr 22, 2025
| @@ -580,90 +577,4 @@ describe("InventoryClient: Refund chain selection", async function () { | |||
| expect(possibleRepaymentChains.length).to.equal(4); | |||
| }); | |||
| }); | |||
|
|
|||
| describe("In-protocol swap", async function () { | |||
There was a problem hiding this comment.
I think this test isn't doing what we think its doing currently. Currently the determineRefundChain should throw if input token and output token are not "equivalent" here and in this test, the input token is native USDC which has no pool rebalance route mappings to bridged USDC, so it should not allow determineRefundChain to return successfully.
nicholaspai
requested review from
mrice32,
james-a-morris,
dohaki and
bmzig
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relayer implementation based on across-protocol/sdk#970
Relayer:
Dataworker: