improve: refactor common interfaces #940
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pxrl
reviewed
Mar 27, 2025
There was a problem hiding this comment.
@james-a-morris How does this work with the existing data posted to arweave?
For the recent contract upgrades we had to define both of them concurrently, and ensure that the newly-named field is auto-populated post retrieval.
There was a problem hiding this comment.
we will need to either bump the arweave version or encode a backfill version
pxrl
reviewed
Mar 27, 2025
pxrl
reviewed
Mar 27, 2025
james-a-morris
force-pushed
the
james/acx-3914-abstract-spokepoolclient-into-evmspokepoolclient
branch
from
1554da9 to
95b0bf0
Compare
james-a-morris
force-pushed
the
james/acx-3913-refactor-sortableevent-types-in-sdk
branch
from
1f75f21 to
e518a21
Compare
james-a-morris
force-pushed
the
james/acx-3913-refactor-sortableevent-types-in-sdk
branch
from
ec71d43 to
7929284
Compare
james-a-morris
changed the base branch from
james/acx-3914-abstract-spokepoolclient-into-evmspokepoolclient
to
master
Signed-off-by: james-a-morris <[email protected]>
Signed-off-by: james-a-morris <[email protected]>
Signed-off-by: james-a-morris <[email protected]>
Signed-off-by: james-a-morris <[email protected]>
james-a-morris
force-pushed
the
james/acx-3913-refactor-sortableevent-types-in-sdk
branch
from
7929284 to
431f57a
Compare
amateima
approved these changes
Apr 8, 2025
|
Conflict in HubPoolClient that need to be solved |
Signed-off-by: james-a-morris <[email protected]>
Signed-off-by: james-a-morris <[email protected]>
Signed-off-by: james-a-morris <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to refactor the common
SortableEventinterface to make it more common between chain families (EVM/SVM)