feat(svmSpokeUtils): svm relayFillStatus implementation #984

melisaguevara · 2025-04-22T15:33:13Z

This PR introduces the SVM implementation for relayFillStatus, which reconstructs the fill status of a given relay based on historical events up to a specific block.

The steps to reconstruct fill status are:

Retrieve the fill status PDA associated with the target relay.
Query all relevant events (fills and slow fill requests) from that PDA, up to the specified block.
Sort the events in ascending order by slot number.
Determine the current fill status based on the most recent event:
- If no events are found, the status is considered Unfilled.
- Otherwise, the status reflects the type of the latest event.

NOTE: This is still a draft since the event fetching logic will change to use the new version of the svm events client from this pr: #982

… instead of fill type

linear · 2025-04-22T15:33:15Z

ACX-4029 implement relayFillStatus

melisaguevara · 2025-04-22T15:51:14Z

src/arch/svm/SpokeUtils.ts

+  // TODO: modify this to use svmEventsClient once we can instantiate it with dynamic addresses.
+  const fillPdaSignatures = await provider
+    .getSignaturesForAddress(fillStatusPda, {
+      limit: 1000,
+      commitment: "confirmed",
+    })
+    .send();
+
+  const eventsWithSlots = await Promise.all(
+    fillPdaSignatures.map(async (signatureTransaction) => {
+      const events = await svmEventsClient.readEventsFromSignature(signatureTransaction.signature);
+      return events.map((event) => ({
+        ...event,
+        confirmationStatus: signatureTransaction.confirmationStatus,
+        blockTime: signatureTransaction.blockTime,
+        signature: signatureTransaction.signature,
+        slot: signatureTransaction.slot,
+      }));
+    })
+  );


I copied this from the SvmSpokeEventsClient but it is temporary and doesn't cover the case where a pda has +1000 events (which should be rare though). I aim to replace it once this PR goes in and we can use the events client for other addresses besides the spoke pool: #982

What is the likelihood we will be using 1000+ signatures of lookback?

Good call. We'd expect these pdas to have only a few events, I'll set a lower value.

melisaguevara · 2025-04-22T15:52:26Z

src/arch/svm/eventsClient.ts

@@ -175,7 +175,7 @@ export class SvmSpokeEventsClient {
   * @param txResult - The transaction result.
   * @returns A promise that resolves to an array of events with their data and name.
   */
-  private processEventFromTx(
+  public processEventFromTx(


These changes are also temporary and might not be needed with the new version of the svm events client.

james-a-morris · 2025-04-22T20:05:22Z

src/arch/svm/SpokeUtils.ts

+  // TODO: modify this to use svmEventsClient once we can instantiate it with dynamic addresses.
+  const fillPdaSignatures = await provider
+    .getSignaturesForAddress(fillStatusPda, {
+      limit: 1000,


OOC should we allow the user to pass this value? It's possible for small ranges (like in the indexer) we want to pass a smaller value for faster read times

I can add it as an optional param and I'll also set the default to a lower value since we'd expect these pdas to have only a few events. Good call.

james-a-morris · 2025-04-22T20:06:21Z

src/arch/svm/SpokeUtils.ts

+  // TODO: modify this to use svmEventsClient once we can instantiate it with dynamic addresses.
+  const fillPdaSignatures = await provider
+    .getSignaturesForAddress(fillStatusPda, {
+      limit: 1000,
+      commitment: "confirmed",
+    })
+    .send();
+
+  const eventsWithSlots = await Promise.all(
+    fillPdaSignatures.map(async (signatureTransaction) => {
+      const events = await svmEventsClient.readEventsFromSignature(signatureTransaction.signature);
+      return events.map((event) => ({
+        ...event,
+        confirmationStatus: signatureTransaction.confirmationStatus,
+        blockTime: signatureTransaction.blockTime,
+        signature: signatureTransaction.signature,
+        slot: signatureTransaction.slot,
+      }));
+    })
+  );


What is the likelihood we will be using 1000+ signatures of lookback?

james-a-morris · 2025-04-22T20:07:30Z

src/arch/svm/SpokeUtils.ts

+export async function relayFillStatus(
+  programId: Address,
+  relayData: RelayData,
+  blockTag: number | "latest",


Nit: is latest the correct term in our case? We'd probably be looking for the most recently "processed" or "confirmed" block

james-a-morris · 2025-04-22T20:08:50Z

src/arch/svm/SpokeUtils.ts

+  // At this point we have only fill and requested slow fill events and since it's not possible to submit
+  // a slow fill request once a fill has been submitted, we can use the last event in the sorted list to
+  // determine the fill status at the requested block.


Do we have corresponding tests for this?

james-a-morris · 2025-04-22T20:09:00Z

src/arch/svm/eventsClient.ts

@@ -175,7 +175,7 @@ export class SvmSpokeEventsClient {
   * @param txResult - The transaction result.
   * @returns A promise that resolves to an array of events with their data and name.
   */
-  private processEventFromTx(
+  public processEventFromTx(


james-a-morris · 2025-04-22T20:10:36Z

src/arch/svm/utils.ts

+export async function getFillStatusPda(
+  programId: Address,
+  relayData: RelayData,
+  destinationChainId: number
+): Promise<Address> {
+  const relayDataHash = getRelayDataHash(relayData, destinationChainId);
+  const uint8RelayDataHash = new Uint8Array(Buffer.from(relayDataHash.slice(2), "hex"));
+  const [fillStatusPda] = await getProgramDerivedAddress({
+    programAddress: programId,
+    seeds: ["fills", uint8RelayDataHash],
+  });
+  return fillStatusPda;
+}


OOC is there a way we can use the function you created to derive the address? I.e. could this just be a wrapper over getStatePda with the specified address/extraSeed

getStatePda and getFillStatusPda use different labels which is the first item in the 'seeds' array. We could have a function wrapping getProgramDerivedAddress that takes the seeds but I don't think there's much value on it.

james-a-morris · 2025-04-22T20:13:16Z

src/utils/SpokeUtils.ts

@@ -71,6 +75,46 @@ export function getRelayHashFromEvent(e: RelayData & { destinationChainId: numbe
  return getRelayDataHash(e, e.destinationChainId);
 }

+function _getRelayDataHashSvm(relayData: RelayData, destinationChainId: number): string {
+  const uint8ArrayFromHexString = (hex: string, littleEndian: boolean = false): Uint8Array => {


OOC - the endianness of the data feels very low level for TS. How often will endianness be a consideration and an we abstract this away from the caller?

We need to set the endianness to replicate the relay hash calculation doing in the Solana program itself but it is already abstracted from the caller. I mean, these helper functions are intended to be used exclusively within _getRelayDataHashSvm so the caller has to provide only the relayData.

melisaguevara · 2025-04-24T21:39:28Z

Closing this in favor of #990

melisaguevara added 7 commits April 21, 2025 17:24

WIP: svm version of get fill deadline buffer

680b0dc

feat: svm get fill deadline buffer

36ed97f

set state pda as a client property

2c19f73

fix programId type

b6eb601

WIP: svm relayFillStatus implementation

31c73b6

query both fill and requested slow fill events and return fill status…

16c3098

… instead of fill type

restore deleted functions

b73a542

fix svm spoke pool return type for relayFillStatus

c3685dd

melisaguevara commented Apr 22, 2025

View reviewed changes

undo delete line

0913bf9

melisaguevara requested review from pxrl and james-a-morris April 22, 2025 17:36

james-a-morris reviewed Apr 22, 2025

View reviewed changes

amateima self-requested a review April 23, 2025 13:23

melisaguevara closed this Apr 24, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(svmSpokeUtils): svm relayFillStatus implementation #984

feat(svmSpokeUtils): svm relayFillStatus implementation #984

melisaguevara commented Apr 22, 2025 •

edited

Loading

linear bot commented Apr 22, 2025

melisaguevara Apr 22, 2025

james-a-morris Apr 22, 2025

melisaguevara Apr 22, 2025

melisaguevara Apr 22, 2025

james-a-morris Apr 22, 2025

james-a-morris Apr 22, 2025

melisaguevara Apr 22, 2025

james-a-morris Apr 22, 2025

james-a-morris Apr 22, 2025

james-a-morris Apr 22, 2025

james-a-morris Apr 22, 2025

james-a-morris Apr 22, 2025

melisaguevara Apr 22, 2025

james-a-morris Apr 22, 2025

melisaguevara Apr 22, 2025

melisaguevara commented Apr 24, 2025

feat(svmSpokeUtils): svm relayFillStatus implementation #984

feat(svmSpokeUtils): svm relayFillStatus implementation #984

Conversation

melisaguevara commented Apr 22, 2025 • edited Loading

linear bot commented Apr 22, 2025

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

melisaguevara commented Apr 24, 2025

melisaguevara commented Apr 22, 2025 •

edited

Loading