Skip to content

Conversation

@csp33
Copy link

@csp33 csp33 commented Dec 10, 2025

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable)

Note

Makes spec.replicas conditional on HPA being disabled in datahub-frontend and datahub-gms Deployment templates to avoid conflicts.

  • Helm Charts:
    • Deployments:
      • charts/datahub/subcharts/datahub-frontend/templates/deployment.yaml: set spec.replicas only when .Values.hpa.enabled is false.
      • charts/datahub/subcharts/datahub-gms/templates/deployment.yaml: refine conditional to set spec.replicas only when .Values.hpa.enabled is false (preserving strict mode/managed ingestion check).

Written by Cursor Bugbot for commit b823706. This will update automatically on new commits. Configure here.

When HPAs are created, replicas shouldn't be specified in the deployments
@github-actions
Copy link

This PR is stale. We will close it in 30 days if there is no comment or activity. If you want feedback but not able to get it on github please head to #contribute channel in slack at https://slack.datahubproject.io.

@github-actions github-actions bot added the stale label Jan 10, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant