Added remote executor terraform deployment for ECS EC2 launch types#35
Added remote executor terraform deployment for ECS EC2 launch types#35max-datahub wants to merge 6 commits intomainfrom
Conversation
… "FARGATE" and "EC2"
…sting subnets & gateway, generated tfvars examples and README
|
You have run out of free Bugbot PR reviews for this billing cycle. This will reset on September 27. To receive reviews on all of your PRs, visit the Cursor dashboard to activate Pro and start your 14-day free trial. |
There was a problem hiding this comment.
This PR is being reviewed by Cursor Bugbot
Details
Your team is on the Bugbot Free tier. On this plan, Bugbot will review limited PRs each billing cycle for each member of your team.
To receive Bugbot reviews on all of your PRs, visit the Cursor dashboard to activate Pro and start your 14-day free trial.
| { | ||
| name = (local.version_legacy ? "DATAHUB_EXECUTOR_WORKER_ID" : "DATAHUB_EXECUTOR_POOL_ID") | ||
| value = (local.version_legacy ? var.datahub.executor_pool_id : var.datahub.executor_id) | ||
| value = (local.version_legacy ? var.datahub.executor_id : var.datahub.executor_pool_id) |
There was a problem hiding this comment.
Bug: Undefined Variable and Executor ID Logic Error
The local.version_legacy variable is referenced but not defined, causing a Terraform compilation error. Additionally, the logic for assigning the executor ID/pool ID value is inverted relative to the environment variable name selection. This inversion may lead to incorrect executor configuration, especially since executor_id is deprecated, potentially impacting existing deployments.
Note
Add EC2 launch type support with supporting infrastructure, refactor inputs/env vars, add outputs, and ship comprehensive examples and docs.
remote-ingestion-executorlaunch_type(EC2orFARGATE) andec2_configinputs.modules/ec2-infrastructureto provision EC2 instance, IAM, SG, and use existing private subnets; expose outputs consumed by service.main.tfto conditionally wire subnets/SGs for EC2, disable public IP on EC2, and passlaunch_typetoecs_service.enable_autoscalinginput; replaceenvironmentwithenv_vars; removerequires_compatibilitiesusage.executor_idandexecutor_pool_id.cluster_name,cluster_arn,service_name,task_definition_arn, plus EC2-onlyprivate_subnet_ids,instance_id.5.9.2.examples/withREADME.md,main.tf, and.tfvars.examplefor Fargate and EC2; expand top-levelREADME.mdwith quick start, architecture, and updated inputs/outputs.Written by Cursor Bugbot for commit 5d62d4f. This will update automatically on new commits. Configure here.