feat(ecs): Add support for tag propagation#39
Open
burahimu wants to merge 2 commits intoacryldata:mainfrom
Open
feat(ecs): Add support for tag propagation#39burahimu wants to merge 2 commits intoacryldata:mainfrom
burahimu wants to merge 2 commits intoacryldata:mainfrom
Conversation
This commit introduces a new propagate_tags variable to the remote ingestion executor module. This allows users to control whether tags from the ECS service or task definition are propagated to the running tasks. This is useful for costs analysis. The variable defaults to SERVICE and accepts SERVICE, TASK_DEFINITION, or NONE as valid values
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 2 potential issues.
Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.
This PR is being reviewed by Cursor Bugbot
Details
Your team is on the Bugbot Free tier. On this plan, Bugbot will review limited PRs each billing cycle for each member of your team.
To receive Bugbot reviews on all of your PRs, visit the Cursor dashboard to activate Pro and start your 14-day free trial.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit introduces a new propagate_tags variable to the remote ingestion executor module. This allows users to control whether tags from the ECS service or task definition are propagated to the running tasks. This is useful for costs analysis.
The variable defaults to NONE and accepts SERVICE, TASK_DEFINITION, or NONE as valid values
Note
Introduces configurable tag propagation for ECS tasks in the remote ingestion executor module.
variable "propagate_tags"with validation and default"NONE"invariables.tfpropagate_tags = upper(var.propagate_tags)inmain.tfWritten by Cursor Bugbot for commit 23b9639. This will update automatically on new commits. Configure here.