Fix cartesian product in agg_monthly_loans causing inflated metrics#8
Draft
Fix cartesian product in agg_monthly_loans causing inflated metrics#8
Conversation
Co-authored-by: jjoyce0510 <17549204+jjoyce0510@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix SQL bug causing duplicate rows in agg_monthly_loans model
Fix cartesian product in agg_monthly_loans causing inflated metrics
Mar 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
agg_monthly_loanswas producing 1,162 rows (expected 10–30) and inflated loan values due to aLEFT JOINback to the rawloanstable on onlyloan_type_name. Sincemonthly_originationsis already aggregated atmonth + loan_typegrain, this join multiplied every aggregated row by every individual loan of that type.Changes
models/marts/agg_monthly_loans.sql: Remove theLEFT JOIN loans ON orig.loan_type_name = loans.loan_type_namefrom thecombinedCTE and drop theloans.customer_idcolumn from the SELECTThe
loansCTE is retained — it's still used bymonthly_originationsfor the initial aggregation.Original prompt
🔒 GitHub Advanced Security automatically protects Copilot coding agent pull requests. You can protect all pull requests by enabling Advanced Security for your repositories. Learn more about Advanced Security.