fix: set DocumentSettings on Shared folder for UI visibility#78
Open
Endiruslan wants to merge 1 commit intoacryldata:mainfrom
Open
fix: set DocumentSettings on Shared folder for UI visibility#78Endiruslan wants to merge 1 commit intoacryldata:mainfrom
Endiruslan wants to merge 1 commit intoacryldata:mainfrom
Conversation
The _ensure_document_exists function creates the root "Shared" folder with show_in_global_context=True passed to Document.create_document(), but the SDK does not emit the DocumentSettings aspect from this param. This causes the Shared folder to have showInGlobalContext=None in the API, making it and all child documents invisible in the DataHub UI Documents page. Apply the same DocumentSettingsClass workaround already used for individual documents (lines 593-605) to the folder creation path. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
_ensure_document_existsfunction creates the root "Shared" folder withshow_in_global_context=Truepassed toDocument.create_document(), but the SDK does not emit theDocumentSettingsaspect from this parametershowInGlobalContext=None, making it and all child documents invisible in the DataHub UI Documents pageDocumentSettingsClassworkaround already used for individual documents (lines 593-605) to the folder creation pathHow to reproduce
TOOLS_IS_MUTATION_ENABLED=truesave_documenttool to create any documentVerified via GraphQL introspection — the folder had
showInGlobalContext: nullwhile documents inside hadshowInGlobalContext: true. After manually setting the aspect via REST API, the folder appeared in the UI.Test plan
save_documentMCP tool to create a document🤖 Generated with Claude Code
Note
Low Risk
Small, localized change to document-folder creation that only adds an extra aspect during upsert; low risk aside from potential SDK/aspect compatibility issues.
Overview
Ensures the root/shared folder created by
save_documentpersists UI visibility by explicitly attaching theDocumentSettingsaspect (showInGlobalContext=true) during_ensure_document_exists, matching the existing workaround already applied to individual document creation.Written by Cursor Bugbot for commit 068c992. This will update automatically on new commits. Configure here.