Skip to content

fix: set DocumentSettings on Shared folder for UI visibility#78

Open
Endiruslan wants to merge 1 commit intoacryldata:mainfrom
Endiruslan:fix/shared-folder-show-in-global-context
Open

fix: set DocumentSettings on Shared folder for UI visibility#78
Endiruslan wants to merge 1 commit intoacryldata:mainfrom
Endiruslan:fix/shared-folder-show-in-global-context

Conversation

@Endiruslan
Copy link

@Endiruslan Endiruslan commented Feb 10, 2026

Summary

  • The _ensure_document_exists function creates the root "Shared" folder with show_in_global_context=True passed to Document.create_document(), but the SDK does not emit the DocumentSettings aspect from this parameter
  • This causes the Shared folder to have showInGlobalContext=None, making it and all child documents invisible in the DataHub UI Documents page
  • Applied the same DocumentSettingsClass workaround already used for individual documents (lines 593-605) to the folder creation path

How to reproduce

  1. Configure MCP server with TOOLS_IS_MUTATION_ENABLED=true
  2. Use save_document tool to create any document
  3. Open DataHub UI → Documents page
  4. The "Shared" folder is not visible; documents inside are only findable via search

Verified via GraphQL introspection — the folder had showInGlobalContext: null while documents inside had showInGlobalContext: true. After manually setting the aspect via REST API, the folder appeared in the UI.

Test plan

  • Create a fresh DataHub instance with Context Documents enabled
  • Use save_document MCP tool to create a document
  • Verify the "Shared" folder appears in the DataHub UI Documents page
  • Verify documents inside the folder are visible and navigable

🤖 Generated with Claude Code


Note

Low Risk
Small, localized change to document-folder creation that only adds an extra aspect during upsert; low risk aside from potential SDK/aspect compatibility issues.

Overview
Ensures the root/shared folder created by save_document persists UI visibility by explicitly attaching the DocumentSettings aspect (showInGlobalContext=true) during _ensure_document_exists, matching the existing workaround already applied to individual document creation.

Written by Cursor Bugbot for commit 068c992. This will update automatically on new commits. Configure here.

The _ensure_document_exists function creates the root "Shared" folder
with show_in_global_context=True passed to Document.create_document(),
but the SDK does not emit the DocumentSettings aspect from this param.

This causes the Shared folder to have showInGlobalContext=None in the
API, making it and all child documents invisible in the DataHub UI
Documents page.

Apply the same DocumentSettingsClass workaround already used for
individual documents (lines 593-605) to the folder creation path.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant