Skip to content

Move away from global MCP instance (Initial work towards library pattern)#83

Open
cccs-eric wants to merge 4 commits intoacryldata:mainfrom
cccs-eric:tools_as_library
Open

Move away from global MCP instance (Initial work towards library pattern)#83
cccs-eric wants to merge 4 commits intoacryldata:mainfrom
cccs-eric:tools_as_library

Conversation

@cccs-eric
Copy link

@cccs-eric cccs-eric commented Feb 17, 2026

Based on this comment, I took an initial pass by removing the global reference to the MCP instance. To keep the PR focused and manageable, I intentionally left out items like managing the DataHub client; I’d prefer to address that in a follow-up PR, but I can include it here if preferred. I preserved the current server behavior, such as ensuring repeated tool registrations for the same server are idempotent. I also improved the developer experience by adding a Makefile target to launch the MCP Inspector.


Note

Medium Risk
Touches core tool-registration plumbing and changes initialization patterns across scripts/tests; behavior should be equivalent but mistakes could lead to missing or duplicate tool registration at runtime.

Overview
Removes reliance on a global FastMCP server by introducing create_mcp_server() and making register_all_tools/get_valid_tools_from_mcp operate on an explicit MCP instance, with idempotent registration now tracked per-instance via a WeakSet.

Updates the CLI entrypoint, integration tests, and helper scripts to construct their own server instance and register tools against it, and adds a make mcp-inspector target (plus docs update) to launch the FastMCP inspector consistently.

Written by Cursor Bugbot for commit edf8b13. This will update automatically on new commits. Configure here.

Copy link

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.

This PR is being reviewed by Cursor Bugbot

Details

Your team is on the Bugbot Free tier. On this plan, Bugbot will review limited PRs each billing cycle for each member of your team.

To receive Bugbot reviews on all of your PRs, visit the Cursor dashboard to activate Pro and start your 14-day free trial.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant