Move away from global MCP instance (Initial work towards library pattern)#83
Open
cccs-eric wants to merge 4 commits intoacryldata:mainfrom
Open
Move away from global MCP instance (Initial work towards library pattern)#83cccs-eric wants to merge 4 commits intoacryldata:mainfrom
cccs-eric wants to merge 4 commits intoacryldata:mainfrom
Conversation
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.
This PR is being reviewed by Cursor Bugbot
Details
Your team is on the Bugbot Free tier. On this plan, Bugbot will review limited PRs each billing cycle for each member of your team.
To receive Bugbot reviews on all of your PRs, visit the Cursor dashboard to activate Pro and start your 14-day free trial.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Based on this comment, I took an initial pass by removing the global reference to the MCP instance. To keep the PR focused and manageable, I intentionally left out items like managing the DataHub client; I’d prefer to address that in a follow-up PR, but I can include it here if preferred. I preserved the current server behavior, such as ensuring repeated tool registrations for the same server are idempotent. I also improved the developer experience by adding a Makefile target to launch the MCP Inspector.
Note
Medium Risk
Touches core tool-registration plumbing and changes initialization patterns across scripts/tests; behavior should be equivalent but mistakes could lead to missing or duplicate tool registration at runtime.
Overview
Removes reliance on a global
FastMCPserver by introducingcreate_mcp_server()and makingregister_all_tools/get_valid_tools_from_mcpoperate on an explicit MCP instance, with idempotent registration now tracked per-instance via aWeakSet.Updates the CLI entrypoint, integration tests, and helper scripts to construct their own server instance and register tools against it, and adds a
make mcp-inspectortarget (plus docs update) to launch the FastMCP inspector consistently.Written by Cursor Bugbot for commit edf8b13. This will update automatically on new commits. Configure here.