Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 248130cd07
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| let Some(old_active) = | ||
| self.pending_native_tab_replacement_for(pid, wid, pending.space, pending.frame) | ||
| else { | ||
| continue; |
There was a problem hiding this comment.
reconcile_native_tabs_for_pid only removes a pending appearance when a replacement activation succeeds, so the continue path here leaves ordinary window appearances in pending_appearances indefinitely. Once that stale marker exists, visible_native_tab_replacement_peer_for can later treat a same-frame sibling as a native-tab replacement even when no real tab handoff is happening, which can suppress a normal managed window after a main-window change. Please clear/expire unmatched appearances once the wsid is resolved and no replacement candidate is found.
Useful? React with 👍 / 👎.
| if group.active == Some(wid) { | ||
| group.active = group.members.iter().copied().next(); | ||
| } |
There was a problem hiding this comment.
When removing an active tab from a group that still has at least two members, this code updates group.active but does not update the promoted window's native_tab role in WindowState. That leaves the new active window marked Suppressed, and suppressed windows are filtered out of manageable/effective-manageable flows, so the surviving tab can drop out of management until another event rewrites roles. The active reassignment should also set the promoted member's role to Active.
Useful? React with 👍 / 👎.
1 participant
No description provided.