Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[a25f45] Headers attribute specified on a cell refers to cells in the same table element - Updated Inapplicable Example 6 #2312

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

giacomo-petri
Copy link
Collaborator

Closes issue: #2268

Role region without acc name is ignored.
Added an aria-label attribute to the table element with role region so that the table is exposed as a region rather than a table (that is currently invalidating the example, by making it applicable).

Need for Call for Review:
This will require a 1 week Call for Review


How to Review And Approve

  • Go to the “Files changed” tab
  • Here you will have the option to leave comments on different lines.
  • Once the review is completed, find the “Review changes” button in the top right, select “Approve” (if you are really confident in the rule) or "Request changes" and click “Submit review”.
  • Make sure to also review the proposed Call for Review period. In case of disagreement, the longer period wins.

Copy link

netlify bot commented Mar 6, 2025

Deploy Preview for act-rules ready!

Name Link
🔨 Latest commit 7fb4e55
🔍 Latest deploy log https://app.netlify.com/sites/act-rules/deploys/67c9cbc7efbdd70008696d25
😎 Deploy Preview https://deploy-preview-2312--act-rules.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Collaborator

@HelenBurge HelenBurge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add https://www.w3.org/TR/wai-aria-1.2/#region in the PR details

Copy link
Collaborator

@daniel-montalvo daniel-montalvo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds reasonable

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants