Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[4e8ab6] Element with role attribute has required states and properties - Removed Combobox Failed Example 6 #2313

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

giacomo-petri
Copy link
Collaborator

Closes issue: #2310

ARIA has removed the aria-controls requirement from combobox, so failed example 6 has been removed.

Need for Call for Review:
This will require a 1 week Call for Review


How to Review And Approve

  • Go to the “Files changed” tab
  • Here you will have the option to leave comments on different lines.
  • Once the review is completed, find the “Review changes” button in the top right, select “Approve” (if you are really confident in the rule) or "Request changes" and click “Submit review”.
  • Make sure to also review the proposed Call for Review period. In case of disagreement, the longer period wins.

Copy link

netlify bot commented Mar 6, 2025

Deploy Preview for act-rules ready!

Name Link
🔨 Latest commit b4eed9a
🔍 Latest deploy log https://app.netlify.com/sites/act-rules/deploys/67c9cff9e624c50008ecfcc2
😎 Deploy Preview https://deploy-preview-2313--act-rules.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants