Skip to content

Conversation

@gnunicorn
Copy link
Contributor

Continuing the efforts on #3129 , this

  • Generalizes the ExecuteReference enum and its childrens, while moving it into acter-core, afd43c5
  • Generalizes the AccountData types in that Reference as well, 97a4583
  • Combines the new set of types into a larger Trait that can be used instead of several smaller traits, 4028094
  • Moves EventMeta into core and generalizes that on the config type trait, 6410f77
  • Starting to move the execution framework by making the utilities functions generic and generilizes the required Store and Model for it, 73b445b
  • Make acter-core slimmer by making strum an optional feature, 5bdc158

Probably best reviewed commit by commit, as each contains specific refactors and changes.

@gnunicorn gnunicorn added the rust label Jun 26, 2025
@github-project-automation github-project-automation bot moved this to Backlog in Product Jun 26, 2025
@gnunicorn gnunicorn changed the title More rust generalization More rust generalization: Executive Reference, Store & Model Jun 26, 2025
@github-actions
Copy link
Contributor

Hey there 👋,
and thanks for the contribution. But it seems like you forgot to

  • 📰 Add a markdown file in .changes/ explaining what changed

@codecov
Copy link

codecov bot commented Jun 26, 2025

Codecov Report

❌ Patch coverage is 91.79463% with 171 lines in your changes missing coverage. Please review.
✅ Project coverage is 38.17%. Comparing base (01f1dc3) to head (8ff21c7).
⚠️ Report is 127 commits behind head on main.

Files with missing lines Patch % Lines
native/core/src/executor.rs 63.11% 45 Missing ⚠️
native/core/src/mocks/store.rs 81.35% 22 Missing ⚠️
native/matrix/src/models/conversion.rs 9.09% 20 Missing ⚠️
native/matrix/src/models/execution.rs 84.53% 15 Missing ⚠️
native/matrix/src/referencing.rs 31.57% 13 Missing ⚠️
native/core/src/store/index.rs 97.50% 10 Missing ⚠️
native/matrix/src/models/meta.rs 96.44% 9 Missing ⚠️
native/matrix/src/activities/object.rs 0.00% 5 Missing ⚠️
native/core/src/referencing/execute_reference.rs 98.82% 4 Missing ⚠️
native/matrix/src/models/tasks/task.rs 0.00% 4 Missing ⚠️
... and 15 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3140      +/-   ##
==========================================
- Coverage   39.24%   38.17%   -1.08%     
==========================================
  Files         824      894      +70     
  Lines       34740    44324    +9584     
==========================================
+ Hits        13634    16921    +3287     
- Misses      21106    27403    +6297     
Flag Coverage Δ
unittest 38.17% <91.79%> (-1.08%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

Status: Backlog

Development

Successfully merging this pull request may close these issues.

2 participants