-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: allow namespace overrides #3797
Conversation
0c48366
to
b55f57c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you please add tests?
Co-authored-by: Nikola Jokic <[email protected]>
@nikola-jokic done |
Hey @fernandezcuesta, Can you also resolve conflicts. Sorry, I can do it for you if you want. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested few updates for clarity.
You need to add import for these:
import metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
Co-authored-by: Nikola Jokic <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM Thanks!
Add the ability to control the destination namespace for each chart, useful when deploying under umbrella charts.
Fix: #3798