Skip to content

Extended settings.xml - Profiles with Repo #813

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Scyjin
Copy link

@Scyjin Scyjin commented Apr 29, 2025

Building Maven Project with dependencies of another Repository then Maven-Central.

This could be extended to support more than one repo.
Also the profile could be cut down to one overall-profile, i think.

I'm more the Backend Guy, hope its ok. :)

Description:
Extended settings.xml generation to include another Repository.
This should provide nessecary Information while building with Maven.
So your build could refer to something like Artifacts in a private github repository.

Related issue:

Check list:

  • Mark if documentation changes are required.
  • Mark if tests were added or updated to cover the changes.

@Copilot Copilot AI review requested due to automatic review settings April 29, 2025 18:19
@Scyjin Scyjin requested a review from a team as a code owner April 29, 2025 18:19
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR extends the generation of the Maven settings.xml file to support an additional custom repository alongside Maven Central. Key changes include:

  • Adding new constants in src/constants.ts to handle repository configuration.
  • Updating authentication and settings generation functions in src/auth.ts to inject repository parameters.
  • Documenting the new repository configuration and inputs in docs/advanced-usage.md and action.yml.

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.

File Description
src/constants.ts New constants added to support custom repository parameters.
src/auth.ts Updated functions to process repository configuration, including profile fallback.
docs/advanced-usage.md Extended documentation to explain repository configuration usage.
action.yml Added new input definitions for repository settings.
Comments suppressed due to low confidence (1)

src/auth.ts:146

  • Add tests to verify that the settings.xml is correctly generated when repository configuration parameters are provided, ensuring that the profiles are included or omitted as intended.
profiles: repoId && profileId && repoUrl ? [profiles] : [],

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant