FirstdataE4: Rename to FirstdataE4V11 #3160
Conversation
In preparation to rename FirstdataE4V27 to FirstdataE4, making the names accurately refer to the support gateway versions. Unit: 32 tests, 157 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed
|
Inquiring about current test creds, but thought I'd throw this up for early scrutiny. |
|
We would also want to cut a minor version before merging this. |
jknipp
left a comment
jknipp
left a comment
There was a problem hiding this comment.
Looks good so far.
Tangential question, when would it make sense to reuse code through inheritance? The v11 and v27+ versions of the adapter share much of the same code. In what cases should or shouldn't we have a base adapter that the other adapters inherit from?
|
@jknipp Good question; we could certainly have taken that path when implementing v28, but it probably doesn't make sense to move to it retroactively in this case. That said, I'm not sure if there are any instances of inheritance strictly for versioning of the same API; I think more often there are common core elements used for multiple endpoints with different functionality. Edit: Quickpay does do this for versioning. |
|
@curiousepic Are we ok to close this? |
|
@jknipp This fell through the cracks, though we might still be waiting on test creds for confirmation? In any case it's something that should still happen. |
|
Marking this "of interest" before a cleanup of stale PRs |
2 participants
In preparation to rename FirstdataE4V27 to FirstdataE4, making the names
accurately refer to the support gateway versions.
Unit:
32 tests, 157 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications
100% passed
Remote:
No currently working test creds.