Gwi 248 card connect update live/test ur ls on adapter #4533
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: --------------------------------------- To be able to pull if there exist the avs_result and cvv_result properties in the MultiResponse object, this commit fixes the MultiResponse class by modifying the logic behind the avs_result and cvv_result method, taking the last response that has avs_result and cvv_result :code different of nil, currently if a transaction returns those values, but the next one return nil, the multiresponse methods pulled the AVS and CVV result from last response transaction. Closes activemerchant#4516 Local Tests: --------------------------------------- 17 tests, 71 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed RuboCop: --------------------------------------- 746 files inspected, no offenses detected
Added `skip_3ds` field support for airwallex along with unit and remote test cases. SEr-229 Unit: 5276 tests, 76200 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed Rubocop: 746 files inspected, no offenses detected Remote: 27 tests, 63 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed
Corrected parameter typo for stored credential to `initial_transaction` in the shift4 implementation along with testing. SER-193 Unit: 5284 tests, 76224 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed Rubocop: 746 files inspected, no offenses detected Remote: 17 tests, 39 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed
For `authorize` and `purchase` transactions we can optionally pass the `customer` object which is similarly used in the transaction endpoint. The value is prepended `cus_` and is required if the payment method is omitted `add_token` was incorrectly sending the whole `authorization` which is a combination of a transaction or customer id and a payment token (based on the `authorization_from` method Remote test for `test_successful_store_and_purchase` includes a commented out test purchase (commented out) because the payment method must go through a 3DS authorization flow before it can be utilized in payment transactions (sandbox only) [Create Customer Object](https://docs.rapyd.net/build-with-rapyd/reference/customer-object#create-customer) SER-228 Unit: 20 tests, 91 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed Remote: 29 tests, 84 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed
Contributor
|
Marking this "of interest" before a cleanup of stale PRs |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In order to use the CardConnect gateway the live and test URL's are updated to
test_url = 'https://fts-uat.cardconnect.com/cardconnect/rest/'
live_url = 'https://fts.cardconnect.com/cardconnect/rest/'
Tests
Unit tests
27 tests, 108 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications
100% passed
Remote tests
23 tests, 52 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications
100% passed
2 Tests were commented, refund and partial_refund would not work because the transaction isn't settled.
Rubocop
746 files inspected, no offenses detected