Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump vue-i18n from 10.0.5 to 10.0.6 in /frontend #1141

Merged
merged 5 commits into from
Mar 8, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/check_dependency_updates.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -168,7 +168,7 @@ jobs:

echo -e "\n### Type Check Results" >> ../reports.md
echo "\`\`\`" >> ../reports.md
yarn nuxi typecheck 2>&1 | sed 's/\[.*\]/\n&\n/g' | tee -a ../reports.md || true
yarn typecheck 2>&1 | sed 's/\[.*\]/\n&\n/g' | tee -a ../reports.md || true
echo "\`\`\`" >> ../reports.md

- name: Create GitHub Issue
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/pr_ci_frontend.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ jobs:
- name: Run Nuxt Type Check
if: always()
working-directory: ./frontend
run: sudo yarn nuxi typecheck
run: sudo yarn typecheck

- name: Run ESLint - Linting
if: always()
Expand Down
3 changes: 2 additions & 1 deletion CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -394,7 +394,8 @@ You can further run the following commands for TypeScript type checks on the fro

```bash
# Within ./frontend:
yarn run postinstall
yarn install # necessary for non-Linux users as node_modules are set via Docker
yarn postinstall # prepare types in frontend/.nuxt
yarn typecheck
```

Expand Down
4 changes: 2 additions & 2 deletions STYLEGUIDE.md
Original file line number Diff line number Diff line change
Expand Up @@ -136,8 +136,8 @@ There is a limited set of package types that are available in the global scope.
Before opening a new PR, it is recommended to first generate the current types, then manually check those types:

1. cd into `frontend`
2. run `yarn run postinstall` to generate types in `frontend/.nuxt`
3. run `yarn nuxi typecheck`
2. run `yarn postinstall` to generate types in `frontend/.nuxt`
3. run `yarn typecheck`

Within VS Code TS errors are visible, however, running these commands will help to ensure the new code does not introduce unintended TS errors at build time. Existing TS errors may be ignored. PRs are always welcome to address these errors!

Expand Down
4 changes: 2 additions & 2 deletions frontend/components/image/ImageOrganization.vue
Original file line number Diff line number Diff line change
Expand Up @@ -7,9 +7,9 @@
<!-- Note: Placeholder image for if no image is provided. -->
<div
v-else
class="flex h-full w-full items-center justify-center rounded-r-md border bg-distinct-text text-layer-1"
class="flex h-full w-full items-center justify-center text-primary-text"
>
<Icon class="mb-1" :name="IconMap.PEOPLE" />
<Icon class="h-[75%] w-[75%]" :name="IconMap.ORGANIZATION" />
</div>
</div>
</template>
Expand Down
7 changes: 4 additions & 3 deletions frontend/components/media/MediaMap.vue
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
<!-- SPDX-License-Identifier: AGPL-3.0-or-later -->
<template>
<div
@click="resetDirectionsControl(map)"
@click="resetDirectionsControl()"
id="map"
class="card-style-base dark:brightness-95 dark:contrast-[90%] dark:hue-rotate-180 dark:invert"
></div>
Expand Down Expand Up @@ -185,6 +185,7 @@ const setSelectedRoute = () => {
};

let map: Map;
let marker: maplibregl.Marker;
let directions: MapLibreGlDirections;

// MARK: Profile Switcher
Expand Down Expand Up @@ -432,7 +433,7 @@ onMounted(() => {
</div>
`);

const marker = new maplibregl.Marker({
marker = new maplibregl.Marker({
color: `${props.markerColors[0]}`,
});

Expand Down Expand Up @@ -503,7 +504,7 @@ onMounted(() => {
directions.interactive = true;
});

resetDirectionsControl(map);
resetDirectionsControl();
});
}
});
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,7 @@ const defaultImageUrls = [

const imageUrls = ref(defaultImageUrls);
const uploadError = ref(false);
const swiperRef = ref<{ swiper: Swiper | null }>(null);
const swiperRef = ref<{ swiper: Swiper | null }>();

interface OrganizationImage {
id: string;
Expand Down
1 change: 0 additions & 1 deletion frontend/components/menu/MenuSubPageSelector.vue
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,6 @@ const defaultIndex = computed(() => {
function changeTab(index: number) {
const selectedRoute = props.selectors[index]?.routeUrl;
if (selectedRoute) {
// @ts-expect-error 'nuxtApp.$localePath' is of type 'unknown'
router.push(nuxtApp.$localePath(selectedRoute));
}
}
Expand Down
2 changes: 1 addition & 1 deletion frontend/components/sidebar/left/SidebarLeft.vue
Original file line number Diff line number Diff line change
Expand Up @@ -123,7 +123,7 @@ const sidebarType = computed(() => {

// TODO: Use real name of organization / event when available from backend.
const placeholderName = route.path.split("/").at(-2)?.replaceAll("-", " ");
const placeholderLogo = "/images/tech-from-below.svg";
const placeholderLogo = "";

const topicsArray: { label: string; value: string }[] = [];

Expand Down
4 changes: 2 additions & 2 deletions frontend/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@
"@nuxt/test-utils": "3.15.4",
"@nuxtjs/color-mode": "3.5.2",
"@nuxtjs/device": "3.2.4",
"@nuxtjs/i18n": "9.1.3",
"@nuxtjs/i18n": "9.3.0",
"@nuxtjs/tailwindcss": "6.12.2",
"@pinia/nuxt": "0.9.0",
"@playwright/test": "1.49.1",
Expand Down Expand Up @@ -76,7 +76,7 @@
"@types/geojson": "7946.0.16",
"@unocss/reset": "65.4.3",
"@vueuse/math": "^12.7.0",
"axios": "1.7.9",
"axios": "1.8.2",
"dotenv": "16.4.7",
"eslint-config-prettier": "10.0.1",
"eslint-flat-config-utils": "2.0.0",
Expand Down
7 changes: 0 additions & 7 deletions frontend/public/images/tech-from-below.svg

This file was deleted.

Loading
Loading