Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

missing test coverage for backend/communities/models.py #1152

Merged
merged 2 commits into from
Mar 10, 2025

Conversation

Abhi-Bohora
Copy link
Contributor

@Abhi-Bohora Abhi-Bohora commented Mar 10, 2025

Contributor checklist


Description

This add a missing test for backend/communities/models.py 11 2 82% 21, 31

communities-models

Related issue

Copy link

netlify bot commented Mar 10, 2025

Deploy Preview for activist-org canceled.

Name Link
🔨 Latest commit 3e8dc00
🔍 Latest deploy log https://app.netlify.com/sites/activist-org/deploys/67cf695d95f5ca00084f712b

Copy link
Contributor

Thank you for the pull request! ❤️

The activist team will do our best to address your contribution as soon as we can. If you're not already a member of our public Matrix community, please consider joining! We'd suggest using Element as your Matrix client, and definitely join the General and Development rooms once you're in. Also consider attending our bi-weekly Saturday developer syncs! It'd be great to meet you 😊

Copy link
Contributor

github-actions bot commented Mar 10, 2025

Maintainer Checklist

The following is a checklist for maintainers to make sure this process goes as well as possible. Feel free to address the points below yourself in further commits if you realize that actions are needed :)

  • The TypeScript, pytest and formatting workflows within the PR checks do not indicate new errors in the files changed

  • The Playwright end to end and Zap penetration tests have been ran and are passing (if necessary)

  • The changelog has been updated with a description of the changes for the upcoming release and the corresponding issue (if necessary)

@andrewtavis
Copy link
Member

Nice @Abhi-Bohora! Do we want to look into the dependency check from here and then jump back to the other tests? We'll try to get to the review here in the coming days 😊

@Abhi-Bohora
Copy link
Contributor Author

@andrewtavis sure, I will take a look and get back to you...😊

@andrewtavis
Copy link
Member

Edited the PR description to show you what I mean about having issues in lists be formatted, btw :) You don't need to do the link yourself. You just do #NUMBER and it works ✨

Copy link
Member

@andrewtavis andrewtavis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From new coverage report:

backend/communities/models.py                         11      0   100%

Thanks for the great work here, @Abhi-Bohora 😊 Really great to have such consistent support on the backend tests!

@andrewtavis andrewtavis merged commit 6c3b44c into activist-org:main Mar 10, 2025
7 checks passed
@Abhi-Bohora Abhi-Bohora deleted the communities-models.py branch March 11, 2025 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants