-
Notifications
You must be signed in to change notification settings - Fork 275
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue-361 : Implement Caching with Redis #1163
Conversation
✅ Deploy Preview for activist-org canceled.
|
Thank you for the pull request! ❤️The activist team will do our best to address your contribution as soon as we can. If you're not already a member of our public Matrix community, please consider joining! We'd suggest using Element as your Matrix client, and definitely join the |
Maintainer ChecklistThe following is a checklist for maintainers to make sure this process goes as well as possible. Feel free to address the points below yourself in further commits if you realize that actions are needed :)
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
First PR Commit Check
- The commit messages for the remote branch of a new contributor should be checked to make sure their email is set up correctly so that they receive credit for their contribution
- The contributor's name and icon in remote commits should be the same as what appears in the PR
- If there's a mismatch, the contributor needs to make sure that the email they use for GitHub matches what they have for
git config user.email
in their local activist repo (can be set withgit config --global user.email "GITHUB_EMAIL"
)
Would be great if you could check the backend workflow errors and do the edits to your files to add the license headers so that the license header workflow is fixed. All files need a machine readable one line comment that indicates what the license is. Please let us know if you have any questions! |
I have fixed most of it. Any suggestions for ruff |
For those you should be able to just remove the packages that aren't used, but are being imported. |
Sorry my bad, it's in |
Should be good to remove :) |
The merge of main should fix many of the tests, @rishabmamgai :) Let's work to figure out any of the remaining issues 😊 |
Would be great if you could pull the most recent changes and then fix the license header issues as well as the ruff and mypy errors, @rishabmamgai :) See this comment above. We can work on the failing tests after that. |
Removing it will not register the cache invalidation signals. But |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@rishabmamgai Ultimately I owe you an apology here as the main maintainer. In discussing these changes in the most recent developer sync we made the decision that now is not the time to add in Redis. Ultimately the service was seen to be too much for a yet to be released platform, and overhead that we as a community can't afford to maintain right now.
The decision was made to document that this implementation was done in the now included Markdown file that will point to this PR as the basis of the eventual implementation of Redis. We will also commit the changes directly so that you get credit for all of the work that you put into this PR.
Again my apologies that your changes will not be integrated into the platform. I should have groomed the issues better and communicated with the community earlier when this level of work began.
You'd be more than welcome to continue to contribute. Really do appreciate the detail and persistence that you put into this PR. Hard to not merge it in, but ultimately we did need to make this decision.
Really thanks for the work here ❤️
Hi @andrewtavis , thanks for the update. I was curious about if the build will run successfully after my last changes. Anyways, hope Redis will be there someday, will be happy to pick it up when it's finally a go go again :). |
I'll definitely reach out when we're ready to work on this again, @rishabmamgai! Hopefully within the year we'll start adding further systems on to it all 😊 Please let us know if there's another issue that'd be of interest. Would be very happy to be able to work with you again :) |
Contributor checklist
Description
Related issue